fix: update Model.list_model_evaluations and get_model_evaluation to use the provided version#1616
Merged
sararob merged 5 commits intogoogleapis:mainfrom Aug 31, 2022
Merged
Conversation
…list_model_evaluations
sasha-gitg
approved these changes
Aug 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model.get_model_evaluationandModel.list_model_evaluationspreviously didn't support Model Registry, so they only returned evaluations for the version set as the default. This fix uses the version a model was instantiated with viaaiplatform.Model(model_name="projects/123/models/456@1"), and passes that versioned resource name to the list and get methods for model evaluations.I'll open a separate PR to add a
list_model_evaluationsmethod to theModelRegistryclass that allows for passing a model version as a parameter.Fixes b/243835689 🦕