Conversation
…es with partial ordering mode
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
Author
|
Notebook failure is "FAILED notebooks/remote_functions/remote_function_usecases.ipynb:: - ResourceExhausted: 429 Too many operations are currently being executed, try again later." not this notebook. |
GarrettWu
reviewed
Sep 24, 2024
| @@ -40,6 +40,16 @@ | |||
| "execution_count": 2, | |||
Contributor
There was a problem hiding this comment.
Line #5. last_30_days = now - datetime.timedelta(days=30)
This is not needed then.
Reply via ReviewNB
Contributor
Author
There was a problem hiding this comment.
Thanks. I just noticed that the max() call is doing a 4+ TB query. I will try to fix that. The trouble with using last_7_days for both is that I was getting empty results for the deps DataFrame. I will use the 30 day comparison for that to avoid the expensive max() call.
GarrettWu
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕