Conversation
…ing vector index on `ARRAY<FLOAT64>` columns
…into b365541165-create_vector_index
bigframes/core/sql.py
Outdated
| create = "CREATE VECTOR INDEX IF NOT EXISTS " | ||
|
|
||
| if len(stored_column_names) > 0: | ||
| escaped_stored = [f"`{name}`" for name in stored_column_names] |
Contributor
There was a problem hiding this comment.
Can we use our existing sql utils to escape the ids? This will also escape special characters
bigframes/core/sql.py
Outdated
| ) | ||
|
|
||
| return f""" | ||
| {create} {index_name} |
Contributor
There was a problem hiding this comment.
Probably should escape index_name too?
bigframes/core/sql.py
Outdated
|
|
||
| return f""" | ||
| {create} {index_name} | ||
| ON `{table_name}`(`{column_name}`) |
Contributor
There was a problem hiding this comment.
Lets reuse existing escaping logic
Comment on lines
+59
to
+60
| if index_name is None: | ||
| index_name = table_id.split(".")[-1] |
Contributor
There was a problem hiding this comment.
would reading into a TableReference be more robust?
Contributor
Author
There was a problem hiding this comment.
Pretty sure it's exactly the same logic there, but makes sense from the perspective of having one place for that logic (in case "." is allowed as a character in the table name someday).
Contributor
Author
There was a problem hiding this comment.
Done in latest commit (along with identifier logic).
…into b365541165-create_vector_index
TrevorBergeron
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal issue 365541165 🦕