Conversation
tswast
reviewed
Oct 30, 2024
bigframes/session/time.py
Outdated
| MIN_RESYNC_SECONDS = 100 | ||
|
|
||
|
|
||
| class BigquerySyncedClock: |
Contributor
There was a problem hiding this comment.
Also, could you make some unit tests for this functionality using freezegun to mock out the system monotonic time? Thanks!
Contributor
Author
There was a problem hiding this comment.
added unit tests in new revision
6037544 to
6299796
Compare
tswast
approved these changes
Oct 31, 2024
Contributor
tswast
left a comment
There was a problem hiding this comment.
Clever! This should really help things out.
Note: I think the benchmarks use a separate process per query if I remember correctly. If so, we might need to update those to take full advantage of this. Might even be worth some sort of "warm up" query before running the benchmarks proper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕