feat!: Enable reading JSON data with dbjson extension dtype#1139
Merged
feat!: Enable reading JSON data with dbjson extension dtype#1139
dbjson extension dtype#1139Conversation
dbjson extension dtypedbjson extension dtype
dbjson extension dtypedbjson extension dtype
tswast
reviewed
Nov 8, 2024
Contributor
tswast
left a comment
There was a problem hiding this comment.
Very cool!
Let's make sure we mark this as a "breaking change" in our release notes (https://github.com/googleapis/release-please/blob/main/README.md#how-should-i-write-my-commits)
Since it's a breaking change for a preview feature, we shouldn't bump to 2.0 though. Let's use the Release-As footer in the commit message to make sure we do a 1.x release. https://github.com/googleapis/release-please/blob/main/README.md#how-do-i-change-the-version-number
7c81975 to
48ca926
Compare
48ca926 to
2707038
Compare
2707038 to
6e1aacc
Compare
tswast
approved these changes
Jan 23, 2025
Comment on lines
-206
to
-211
| # b/381148539 | ||
| def test_json_in_struct(): | ||
| df = bpd.read_gbq( | ||
| "SELECT STRUCT(JSON '{\\\"a\\\": 1}' AS data, 1 AS number) as struct_col" | ||
| ) | ||
| assert df["struct_col"].struct.field("data")[0] == '{"a":1}' |
Contributor
There was a problem hiding this comment.
Should we keep / update this test, instead? I'd like to make sure we avoid regressions since I believe this was added to make sure we can work with some AI/ML/ObjectRef features.
Contributor
Author
There was a problem hiding this comment.
Yes, I moved this test to test_dataframe_io.py. Also add similar tests for both struct and array
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
shuoweil
pushed a commit
that referenced
this pull request
Jan 24, 2025
This change updates how we handle JSON data types read from BigQuery. Previously, BigQuery JSON types were treated as generic large strings within our system. To improve accuracy and functionality, we now map them to a dedicated JSON data type (db_dtypes.JSONType or db_dtypes.JSONArrowType for pyarrow). While this provides a more appropriate representation of JSON data, it's important to note that this feature is still in preview and may evolve. Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Tim Sweña (Swast) <swast@google.com> Release-As: 1.34.0
shuoweil
pushed a commit
that referenced
this pull request
Jan 24, 2025
This change updates how we handle JSON data types read from BigQuery. Previously, BigQuery JSON types were treated as generic large strings within our system. To improve accuracy and functionality, we now map them to a dedicated JSON data type (db_dtypes.JSONType or db_dtypes.JSONArrowType for pyarrow). While this provides a more appropriate representation of JSON data, it's important to note that this feature is still in preview and may evolve. Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Tim Sweña (Swast) <swast@google.com> Release-As: 1.34.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat!: Enable reading JSON data with dbjson extension dtype (#1139)
This change updates how we handle JSON data types read from BigQuery.
Previously, BigQuery JSON types were treated as generic large strings within our system. To improve accuracy and functionality, we now map them to a dedicated JSON data type (
db_dtypes.JSONTypeordb_dtypes.JSONArrowTypefor pyarrow).While this provides a more appropriate representation of JSON data, it's important to note that this feature is still in preview and may evolve.
Release-As: 1.34.0
Fixes internal issue 377764399 🦕