Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

docs: add an "open in BQ Studio" link to all BigFrames sample notebooks#1223

Merged
shuoweil merged 14 commits intomainfrom
shuowei-open-bq-studio
Dec 17, 2024
Merged

docs: add an "open in BQ Studio" link to all BigFrames sample notebooks#1223
shuoweil merged 14 commits intomainfrom
shuowei-open-bq-studio

Conversation

@shuoweil
Copy link
Contributor

Add an "open in BQ Studio" link to all BigFrames sample notebooks

bug: b/383391680

@shuoweil shuoweil requested a review from a team as a code owner December 16, 2024 21:32
@shuoweil shuoweil requested review from a team and shobsi December 16, 2024 21:32
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Dec 16, 2024
@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels Dec 16, 2024
@shuoweil shuoweil requested review from GarrettWu and removed request for shobsi December 16, 2024 21:33
@shuoweil shuoweil assigned shuoweil and unassigned rey-esp Dec 16, 2024
@@ -49,7 +49,13 @@
" <img src=\"https://lh3.googleusercontent.com/UiNooY4LUgW_oTvpsNhPpQzsstV5W8F7rYgxgGBD85cWJoLmrOzhVs_ksK_vgx40SHs7jCqkTkCk=e14-rj-sc0xffffff-h130-w32\" alt=\"Vertex AI logo\">\n",
Copy link
Contributor

@GarrettWu GarrettWu Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong link?


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

@shuoweil shuoweil merged commit e0a8288 into main Dec 17, 2024
@shuoweil shuoweil deleted the shuowei-open-bq-studio branch December 17, 2024 00:23
" </td> \n",
" </td>\n",
" <td>\n",
" <a href=\"https://pantheon.corp.google.com/bigquery?project=bigframes-dev&ws=!1m7!1m6!12m5!1m3!1sbigframes-dev!2sus-central1!3se8c41ea1-e159-4865-b2b8-5b784176193f!2e2\">\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to avoid references to internal tools. Use public console.cloud.google.com

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am working on it. These links have been removed since last week to avoid resource leakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants