perf: Fall back to ordering by bq pk when possible#1350
Merged
TrevorBergeron merged 6 commits intomainfrom Feb 3, 2025
Merged
Conversation
9febc06 to
c5c06dc
Compare
tswast
reviewed
Feb 3, 2025
Contributor
tswast
left a comment
There was a problem hiding this comment.
Just a nit on naming, otherwise looks good!
| return index_cols | ||
|
|
||
|
|
||
| def get_time_travel_datetime_and_table_metadata( |
Contributor
Author
There was a problem hiding this comment.
yes, dead and now, gone
tswast
approved these changes
Feb 3, 2025
tswast
reviewed
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕