feat: warn if default ingress_settings is used in remote_functions#1419
Merged
chelsea-lin merged 7 commits intomainfrom Mar 3, 2025
Merged
feat: warn if default ingress_settings is used in remote_functions#1419chelsea-lin merged 7 commits intomainfrom
chelsea-lin merged 7 commits intomainfrom
Conversation
55fdddb to
6a92106
Compare
tswast
reviewed
Feb 25, 2025
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
5ea80fb to
8c762af
Compare
shobsi
reviewed
Feb 28, 2025
Co-authored-by: Shobhit Singh <shobs@google.com>
tswast
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies the default ingress_settings to a sentinel object (None). While this initially defaults to 'all', a warning is now issued to users, indicating that the default will change and 'all' is less secure than 'internal-only'.
Fixes internal issue 397677177🦕