Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

fix: use value equality to check types for unix epoch functions and timestamp diff#1690

Merged
sycai merged 4 commits intomainfrom
sycai_fix
May 5, 2025
Merged

fix: use value equality to check types for unix epoch functions and timestamp diff#1690
sycai merged 4 commits intomainfrom
sycai_fix

Conversation

@sycai
Copy link
Contributor

@sycai sycai commented May 5, 2025 •
edited
Loading

Otherwise the user could run into issues after manual type casts.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 5, 2025
@sycai sycai marked this pull request as ready for review May 5, 2025 21:12
@sycai sycai requested a review from a team as a code owner May 5, 2025 21:12
@sycai sycai requested review from a team and shobsi May 5, 2025 21:12
@sycai sycai enabled auto-merge (squash) May 5, 2025 21:12
@sycai sycai merged commit 81e8fb8 into main May 5, 2025
19 of 24 checks passed
@sycai sycai deleted the sycai_fix branch May 5, 2025 23:59
@release-please release-please bot mentioned this pull request May 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

@shobsi shobsi Awaiting requested review from shobsi

Assignees

@shobsi shobsi

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sycai @TrevorBergeron @shobsi