Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

feat: include index columns in DataFrame.sql if they are named#788

Merged
Genesis929 merged 1 commit intomainfrom
tswast-test-df-sql
Jun 14, 2024
Merged

feat: include index columns in DataFrame.sql if they are named#788
Genesis929 merged 1 commit intomainfrom
tswast-test-df-sql

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Jun 13, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tswast tswast requested a review from a team as a code owner June 13, 2024 18:21
@tswast tswast requested review from a team and Genesis929 June 13, 2024 18:21
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jun 13, 2024
@Genesis929 Genesis929 merged commit c8d16c0 into main Jun 14, 2024
@Genesis929 Genesis929 deleted the tswast-test-df-sql branch June 14, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants