Conversation
tswast
reviewed
Jul 25, 2024
Contributor
tswast
left a comment
There was a problem hiding this comment.
Thanks Trevor!
Should we add an e2e test for the .fit(X, y) table with null index / unordered mode, too?
Contributor
Author
Good idea. This revealed that ml modules were caching pre-join, which is invalidated by row-identity join. Instead, I made it cache post-join. |
GarrettWu
reviewed
Jul 30, 2024
bigframes/ml/core.py
Outdated
| input_data = X_train.cache() | ||
| else: | ||
| input_data = X_train.cache().join(y_train.cache(), how="outer") | ||
| input_data = X_train.join(y_train.cache(), how="outer").cache() |
Contributor
There was a problem hiding this comment.
this should be y_train without cache() as well?
| def test_unordered_mode_logistic_regression_configure_fit_score( | ||
| unordered_session, penguins_table_id, dataset_id | ||
| ): | ||
| model = bigframes.ml.linear_model.LogisticRegression() |
Contributor
There was a problem hiding this comment.
Not a problem, but if we only pick one model to test some shared functionalities, usually the choice is LinearReg.
Contributor
Author
There was a problem hiding this comment.
ok, used linear regression model instead
15083b0 to
47a78bf
Compare
tswast
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕