Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

fix: Fix read_gbq with ORDER BY query and index_col set#963

Merged
TrevorBergeron merged 3 commits intomainfrom
order_by_cluster_fix
Mar 17, 2025
Merged

fix: Fix read_gbq with ORDER BY query and index_col set#963
TrevorBergeron merged 3 commits intomainfrom
order_by_cluster_fix

Conversation

@TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested a review from a team as a code owner September 5, 2024 18:12
@TrevorBergeron TrevorBergeron requested review from a team and sycai September 5, 2024 18:12
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 5, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Sep 5, 2024
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test so we avoid regressions.

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Sep 5, 2024
@TrevorBergeron TrevorBergeron merged commit de46d2f into main Mar 17, 2025
23 checks passed
@TrevorBergeron TrevorBergeron deleted the order_by_cluster_fix branch March 17, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants