From d079fa293ff0e2c4db0e663543050551596907c2 Mon Sep 17 00:00:00 2001 From: Shobhit Singh Date: Wed, 4 Sep 2024 17:59:57 +0000 Subject: [PATCH 1/2] test: retry streaming tests to accommodate flakiness --- tests/system/large/test_streaming.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/system/large/test_streaming.py b/tests/system/large/test_streaming.py index 391aec8533..383e43fa28 100644 --- a/tests/system/large/test_streaming.py +++ b/tests/system/large/test_streaming.py @@ -14,10 +14,13 @@ import time +import pytest + import bigframes import bigframes.streaming +@pytest.mark.flaky(retries=2, delay=120) def test_streaming_df_to_bigtable(session_load: bigframes.Session): # launch a continuous query job_id_prefix = "test_streaming_" @@ -51,6 +54,7 @@ def test_streaming_df_to_bigtable(session_load: bigframes.Session): query_job.cancel() +@pytest.mark.flaky(retries=2, delay=120) def test_streaming_df_to_pubsub(session_load: bigframes.Session): # launch a continuous query job_id_prefix = "test_streaming_pubsub_" From 7904a89c4f6dfd412f5d58b5cd39462231b15679 Mon Sep 17 00:00:00 2001 From: Shobhit Singh Date: Wed, 4 Sep 2024 23:56:32 +0000 Subject: [PATCH 2/2] reduce delay, increase retries --- tests/system/large/test_streaming.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/system/large/test_streaming.py b/tests/system/large/test_streaming.py index 383e43fa28..e4992f8573 100644 --- a/tests/system/large/test_streaming.py +++ b/tests/system/large/test_streaming.py @@ -20,7 +20,7 @@ import bigframes.streaming -@pytest.mark.flaky(retries=2, delay=120) +@pytest.mark.flaky(retries=3, delay=10) def test_streaming_df_to_bigtable(session_load: bigframes.Session): # launch a continuous query job_id_prefix = "test_streaming_" @@ -54,7 +54,7 @@ def test_streaming_df_to_bigtable(session_load: bigframes.Session): query_job.cancel() -@pytest.mark.flaky(retries=2, delay=120) +@pytest.mark.flaky(retries=3, delay=10) def test_streaming_df_to_pubsub(session_load: bigframes.Session): # launch a continuous query job_id_prefix = "test_streaming_pubsub_"