Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
This repository was archived by the owner on Feb 26, 2026. It is now read-only.

fix: fix system test for mtls#485

Merged
daniel-sanche merged 1 commit intomainfrom
fix_mtls
Feb 10, 2022
Merged

fix: fix system test for mtls#485
daniel-sanche merged 1 commit intomainfrom
fix_mtls

Conversation

@arithmetic1728
Copy link
Contributor

mtls is only available for grpc clients, so we need to skip those system tests for http clients. This fixes: b/218322984

@arithmetic1728 arithmetic1728 requested a review from a team February 7, 2022 21:41
@arithmetic1728 arithmetic1728 requested a review from a team as a code owner February 7, 2022 21:41
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: logging Issues related to the googleapis/python-logging API. labels Feb 7, 2022
@arithmetic1728
Copy link
Contributor Author

@daniel-sanche I don't think the app engine test failure is related to my change since my change has no effect unless mTLS specific env var is set.

@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2022
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2022
@daniel-sanche daniel-sanche merged commit 96bb6f7 into main Feb 10, 2022
@daniel-sanche daniel-sanche deleted the fix_mtls branch February 10, 2022 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/python-logging API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants