Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

docs: Use cached versions of Cloud objects.inv files#863

Merged
rwhogg merged 1 commit intogoogleapis:mainfrom
rwhogg:fix-docs
Feb 6, 2023
Merged

docs: Use cached versions of Cloud objects.inv files#863
rwhogg merged 1 commit intogoogleapis:mainfrom
rwhogg:fix-docs

Conversation

@rwhogg
Copy link
Contributor

@rwhogg rwhogg commented Feb 6, 2023

The objects.inv files for two different library deps are currently inaccessible due to redirects.

In the meantime, allow continuing to build the docs by caching them locally.

They are second in the list, so if the original URL's start serving the files themselves, there will be no need to update conf.py again. The cache is strictly a fallback.

Fixes #862

@rwhogg rwhogg requested review from a team as code owners February 6, 2023 22:05
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Feb 6, 2023
@dandhlee dandhlee added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2023
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment.

The objects.inv files for two different library deps
are currently inaccessible due to redirects.

In the meantime, allow continuing to build the docs by caching
them locally.

They are second in the list, so if the original URL's
start serving the files themselves, there will be no need
to update conf.py again. The cache is strictly a fallback.

Fixes googleapis#862
@dandhlee dandhlee added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2023
@rwhogg rwhogg merged commit 4471e2f into googleapis:main Feb 6, 2023
@rwhogg rwhogg deleted the fix-docs branch February 6, 2023 23:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/python-ndb API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building documentation currently fails due to missing object.inv

2 participants