Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for CloudFront or other CDN #505

Closed
Apreche opened this issue Oct 11, 2021 · 11 comments
Closed

Support for CloudFront or other CDN #505

Apreche opened this issue Oct 11, 2021 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@Apreche
Copy link

Apreche commented Oct 11, 2021

Is your feature request related to a problem? Please describe.
listmonk already has support for uploading media into an S3 bucket. That's terrific. However, it is not always desirable to deliver content directly from the bucket itself. It is extremely common to put a CDN, usually AWS CloudFront, in front of the S3 bucket to handle the actual content delivery. Uploads still go to the S3 bucket, but the URLs in the emails would point at the CloudFront URL.

Describe the solution you'd like
Allow configuration of a CloudFront/CDN URL from which media uploaded to S3 will be delivered. When rendering emails, construct URLs pointing at the CDN host instead of at the S3 bucket directly.

@Apreche Apreche added the enhancement New feature or request label Oct 11, 2021
@knadh
Copy link
Owner

knadh commented Oct 11, 2021

Hadn't thought about this. Will consider adding an optional CDN URL.

@ciceroverneck
Copy link

I was needing this

Now I need to use the custom url in the admin (/admin/campaigns/media)

image

@knadh
Copy link
Owner

knadh commented Feb 7, 2022

This feature is already merged and will be available in the upcoming release this week.

@ciceroverneck
Copy link

Yep, but in /admin/campaings/media still using the s3 link

@knadh
Copy link
Owner

knadh commented Feb 8, 2022

Sorry, I am a bit confused. Are you running master or v2.0.0? Once a custom public URL is configured, it will be used everywhere, in the admin and in e-mails.

@ciceroverneck
Copy link

I'm using docker image: listmonk/listmonk:rc5

@ciceroverneck
Copy link

I just updated to v2.1.0, and from /admin/campaigns/media the images keep loading from the aws link.

/reopen

@knadh
Copy link
Owner

knadh commented Mar 2, 2022

Please share a screenshot of your S3 settings UI.

@ciceroverneck
Copy link

I'm using Google Cloud Storage interop with S3 API. Images are being saved correctly in the bucket.

image

@knadh
Copy link
Owner

knadh commented Mar 4, 2022

The public URL seems to be incorrect. It should be something like https://cc-newslatter.storage.googleapis.com, right?

@ciceroverneck
Copy link

No, I use my own CDN that uses the same domain for multiple buckets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants