Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can deselect sequential test runs after importing a programming exercise from a zip file. #9114

Open
hornflip opened this issue Jul 24, 2024 · 1 comment

Comments

@hornflip
Copy link

Describe the bug

If one enables sequential test runs, as far as my understanding goes, the test-repo directory structure changes (sequential and behavorial are separated) and therefore one is not able to disable sequential test runs later on.

We downloaded an exercise with enabled sequential test runs and when we uploaded the .zip file we were able to deselect sequential test runs.

So either disable the sequential test run selection box while importing an exercise from uploading a zip file or allow enabling/disabling sequential testruns by restructuring the test-repo (put all test cases in the same test/ folder, or vice versa move MethodTest.java etc. in a seperate package).

To Reproduce

  1. Create Test Exercise > Choose Title, short name and package name, enable Sequential Test Runs, set points to 1
  2. Click on Generate
  3. Navigate to Instructor view of the exercise
  4. Click on Download Exercise
  5. Navigate to Instructor view of the course
  6. Click on Import programming Exercise > From file > select downloaded exercise
  7. Click on Upload Programming Exercise for Import
  8. Alter Title and short name, disable Sequential Test Runs
  9. Click on Import

Expected behavior

I can't (de)select Sequential Test Runs

Screenshots

No response

Which version of Artemis are you seeing the problem on?

7.4.3

What browsers are you seeing the problem on?

Firefox

Additional context

No response

Relevant log output

No response

@hornflip hornflip added the bug label Jul 24, 2024
@Strohgelaender
Copy link
Contributor

(I belive) that this is on purpose. Similar to how you can activate or deactive SCA during import, this can help if the feature was unintentionally (de)activated for the initial exercise. During the import this only affects the created buld plans, but not the structure in the repositories. While you are correct that this can lead to an inconsistent exercise setup, this can also fix such setup if the instructor removed the sequential testing part and now wants to update the exercise configuration.

I can see how this leads to confusion any potentially wrong configurations. Maybe we can find a way to make the effect more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants