-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translation templates (introduced in Modelica 3.6) #4267
base: master
Are you sure you want to change the base?
Conversation
@casella Feel free to update the milestone if this is not yet considered for MSL 4.1.0. I didn't want to miss the opportunity though what's possible with new MoLang 3.6. |
Not only the original english texts shall be updated. Ideally, also all translations. (So maybe we would need "Language officers" as well. :-D ) And, in oder to populatize the multilingual feature, making public a routine for generation of pot-files from english documentation would be beneficial. |
I don't think we should add it for this release (possibly except the file-settings):
BTW: Dymola 2024x can generate such templates with I guess we should document that more. Additionally it is somewhat complicated to compare the files due to the sorting. I would prefer if we avoid that sorting. I checked Complex and to me it seems as if the templates are based on an earlier version (e.g. " c3 = sum(conj(c1[k]) * c2[k] for k in 1:n)\n" from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files don't seem up-to-date.
I would also prefer if the strings weren't sorted, and I'm not sure if we should add it for this release.
Nice. My first try here https://github.com/tobolar/Credibility/tree/multilingualDescriptions |
Yes, that was also my assumption that both template and translations should be part of the repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, we don't have support for library translations yet in System Modeler, so I'm unable to try this out.
Discussed this in today's MAP-Lib meeting, not realistic for 4.1.0 -> shift the milestone |
Now that we enabled (soft) MoLang 3.6 features, we can easily add the translation template files. Of course, they need to be updated each time before tagging a release. Therefore the strings are sorted by identifier to have it diff-friendly.
@HansOlsson @henrikt-ma Please check in Dymola and WSM, respectively, if the files are correctly generated.