Make type explicit for fill operator #4393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casella
approved these changes
Jun 22, 2024
There was a problem hiding this comment.
I'm not sure I see the point of this PR, since all these functions have a third input which is a subtype of Real; as Modelica defines automatic conversions from Integer to Real, is there any difference?
Besides, the default is actually an empty array.
That said, I don't see anything wrong with this change, even if I don't get the point 😃
|
@arunkumar-narasimhan can you please review this PR so that it gets merged in? @Esther-Devakirubai this can also be ported to maint/v4.1.x. Thanks! |
arunkumar-narasimhan
approved these changes
Aug 19, 2024
|
Backporting this to maint 4.1.x by #4462 |
casella
pushed a commit
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is derived from #4389. It helps tools to correctly deduce the array type, just by checking the argument of fill.
Note, that it already was a mixed usage of Integer zero and Real zero in Media functions.