Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline copyright missing from license file #3796

Open
vw-anton opened this issue Jun 6, 2024 · 3 comments
Open

Multiline copyright missing from license file #3796

vw-anton opened this issue Jun 6, 2024 · 3 comments
Labels

Comments

@vw-anton
Copy link

vw-anton commented Jun 6, 2024

Description

We found a package where author/copyright information is missing from a license file.
It looks like only the first author of a list is represented in the scan result.

How To Reproduce

https://github.com/formidablelabs/victory.git
commit dd86278d205f3f306e2ab38c317a6f9c56f0a6f8

Copyrights found:

 copyrights:
      - statement: "Copyright (c) 2014-present, Facebook, Inc."
        location:
          path: "packages/victory-core/src/victory-util/immutable-types.d.ts"
          start_line: 2
          end_line: 2
      - statement: "Copyright (c) 2015-2020 Formidable Labs"
        location:
          path: "LICENSE.txt"
          start_line: 3
          end_line: 3
      - statement: "Copyright (c) 2016-2020 Alexey Svetliakov <https://github.com/asvetliakov>"
        location:
          path: "LICENSE.txt"
          start_line: 5
          end_line: 5

However in the LICENSE.txt file we can see:

Copyright (c) 2016-2020 Alexey Svetliakov <https://github.com/asvetliakov>,
snerks <https://github.com/snerks>, Krzysztof Cebula <https://github.com
Havret>, Vitaliy Polyanskiy <https://github.com/alreadyExisted>, James Lismore
<https://github.com/jlismore>, Stack Builders <https://github.com
stackbuilders>, Esteban Ibarra <https://github.com/ibarrae>, Dominic Lee
<https://github.com/dominictwlee>, Dave Vedder <https://github.com
veddermatic>, Alec Flett <https://github.com/alecf> and potentially other
DefinitelyTyped contributors.

System configuration

For bug reports, it really helps us to know:

  • What OS are you running on? (Windows/MacOS/Linux)
    • Linux
  • What version of scancode-toolkit was used to generate the scan file?
    • 32.1.0
  • What installation method was used to install/run scancode? (pip/source download/other)
    • Python (via ORT 22.5.0)
@vw-anton vw-anton added the bug label Jun 6, 2024
@pombredanne
Copy link
Contributor

Good catch!
FWIW the file at https://github.com/FormidableLabs/victory/blob/main/LICENSE.txt is problematic in multiple ways:

  • URLs are truncated and are missing slashes meaning they are no longer detectable as proper full URLs.
  • the result of the URL split means that we have random org names instead of proper detectable words
  • the trailing " and potentially other DefinitelyTyped contributors." is at best artistic and not something that makes sense
  • In addition to this, the MIT license text has been reordered and is no longer an MIT, nut an MIT0 with the main clause moved after the disclaimer.

See FormidableLabs/victory@591fba6

@vw-anton
Copy link
Author

vw-anton commented Jun 6, 2024

So how to proceed on that?

@vw-anton
Copy link
Author

vw-anton commented Jul 2, 2024

@pombredanne Any comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants