Use SCTK package_only in inspect_packages pipeline
#1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdruez
requested changes
Mar 18, 2024
There was a problem hiding this comment.
@AyanSinhaMahapatra What's the latest status on a SCTK release? Also, could you add a changelog entry for those changes?
|
@AyanSinhaMahapatra please provide context and changelog for those changes. |
* Split package/dependencies creation in a seperate step * Only create packages/dependencies from Assemblable PackageData Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Support the new only_packages attributes in scancode get_package_data API, to only scan for package data and skip license and copyright detection. Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
package_only in inspect_packages pipeline
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
1959835
to
1ebf507
Compare
|
@tdruez I've rebased the changes on the latest main, where we have the new SCTK release v32.1.0, and I've also added more context for the changes in PR description above and added a CHANGELOG entry, this is ready to review now. Thanks! |
Reference: #1087 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
8909dee
to
11b0b35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes in
inspect_packagespipeline:package_onlyattribute in theget_package_dataAPI which is equivalent to the new --package-only CLI option in SCTK. This is an optional attribute, which is set True, only scans package manifests for package data, and skips license and copyright detected on extracted license statements and copyrights, hence making this step faster.inspect_packagespipeline introduced in Restructure pipelines for verbosity #1074:models.NonAssemblableDatafileHandler(like autotools configure scripts for example: https://github.com/nexB/scancode-toolkit/blob/develop/src/packagedcode/build.py#L50C33-L50C68)