Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address book settings: style changes and add NcTextField #4039

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

GVodyanov
Copy link
Contributor

@GVodyanov GVodyanov commented Jul 18, 2024

Fix #4024

A B
Screenshot from 2024-07-18 12-14-37 Screenshot from 2024-07-18 12-10-02

Changelog:

  • Share icon is now square
  • Add address book icon has a plus
  • Instead of having a boring form and HTML input, we have an ✨NcTextField

Small complaint about NcTextField though, to submit you have to use the @trailing-button-click event, and using the Enter key on the field doesn't trigger it

Also, due to the custom event, using min-length doesn't work, and you have to check whether there are any characters inputted in the triggered method.

@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Jul 18, 2024
@GVodyanov GVodyanov self-assigned this Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.90%. Comparing base (febfa20) to head (1f97e7d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4039   +/-   ##
=========================================
  Coverage     65.90%   65.90%           
  Complexity      261      261           
=========================================
  Files            24       24           
  Lines           786      786           
=========================================
  Hits            518      518           
  Misses          268      268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov GVodyanov force-pushed the style/improve-address-book-adding branch from 44187dd to 1f97e7d Compare July 18, 2024 10:41
@hamza221 hamza221 merged commit fbe36e1 into main Jul 23, 2024
26 checks passed
@hamza221 hamza221 deleted the style/improve-address-book-adding branch July 23, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign address book sharing dialogue
2 participants