Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG REPORT] Edalize does not support the use of vlogdefine parameters with no value #460

Open
amal-araweelo opened this issue Feb 13, 2025 · 2 comments

Comments

@amal-araweelo
Copy link

SystemVerilog allows you to use a macro name without setting it to a value, but this is not supported by Edalize:

Required Data type of the parameter. Valid values are bool, file, int, str. file is similar to str, but the value is treated as a path and converted to an absolute path

Even so, the VCS backend assumes that all vlogdefines do have a value:

...
                for k, v in vlog_defines.items():
                    _args.append(
                        "+define+{}={}".format(
                            k, self._param_value_str(v, str_quote_style='""')
                        )
                    )
...
@olofk
Copy link
Owner

olofk commented Feb 13, 2025

I have looked at this before. It's possible to solve but it's a bit tricky. Can you work around it by just setting the define to 1 or something similar? That's typically what I do in these cases.

@amal-araweelo
Copy link
Author

amal-araweelo commented Feb 19, 2025

In the design or just the .core file? It would be nice not to have to change the rtl code to accommodate this bug, if possible. @olofk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants