Label color

[ActiveChooN]

Motivation and context

This PR helps user to change predefined label color. When creating a label, it is assigned a color from a color map. Also ability to change this color from UI is available.

Resolve #1480, resolve #1572, closes #842

How has this been tested?

Manually

Checklist

• I submit my changes into the develop branch
• I have added description of my changes into CHANGELOG file
  - [ ] I have updated the documentation accordingly
  - [ ] I have added tests to cover my changes
• I have linked related issues (read github docs)
• I have increased versions of npm packages if it is necessary (cvat-canvas,
  cvat-core, cvat-data and cvat-ui)

License

• I submit my code changes under the same MIT License that covers the project.
  Feel free to contact the maintainers if that's a concern.
• I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

[zhiltsov-max]

The function is not used anymore, but it should be to avoid problems with symbol case and special characters.

The logic is:

• sort labels to provide stable results (across different tasks with same labels)
• find matching labels using normalization
• if have conflicts, the first match uses the table
• generate random colors for the rest

[ActiveChooN]

Now colors are set at the time of label creation. So i guess sorting by its name can not provide stable result now. I can not create labels with the same name, so are there any conflicts?

[zhiltsov-max]

Conflicts appear from labels like BACKGROUND, _BA_CK_gro_und_, back_GROUND etc after their normalization. I feel that sorting might be unnecessary anymore, or should be done in label creation code, when it is done in batch mode.

[coveralls]

Pull Request Test Coverage Report for Build 7036

• 55 of 66 (83.33%) changed or added relevant lines in 4 files are covered.
• 4 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.007%) to 69.729%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
cvat/apps/engine/serializers.py	11	12	91.67%
cvat/apps/dataset_manager/formats/utils.py	42	52	80.77%

Files with Coverage Reduction	New Missed Lines	%
src/labels.js	4	82.86%

Totals
Change from base Build 6998:	0.007%
Covered Lines:	11750
Relevant Lines:	16392

---

💛 - Coveralls

[zhiltsov-max]

I feel like some kind of a button to cancel current label color changes could be useful somewhere around the palette

Looks good.

[bsekachev]

@ActiveChooN

When we change label color on the annotation view (Enter shortcut), is it expected to be changed on a server?
Annotation view color picker still has default preset of colors, are you planning to change it?

[nmanovic]

@ActiveChooN ,

What is the status of the PR?

Several comments from my side:

• Need to have a button "OK" when you select a color, "Cancel", and "Reset to default"
• "Label color" should be replaced by a color pictogram. Color feedback is important.
• Check with Maxim why road is turquoise by default? It looks unusual.

[ActiveChooN]

@nmanovic, finishing work on annotation view. I'm totally agree about "reset to default". But changing color proceed immediately after picking. So I don't think button "Ok" is necessary. What do you think?

[nmanovic]

finishing work on annotation view. I'm totally agree about "reset to default". But changing color proceed immediately after picking. So I don't think button "Ok" is necessary. What do you think?

I think that need to replace "Label color" by a color pictogram for sure. I think that colors for default labels should be reviewed one more time. Also press X isn't intuitive way to choose a color.

[nmanovic]

@ActiveChooN , looks like colors of labels are not matched between the task view and annotation view. Is it something you are working right now?

[nmanovic]

Let's add a similar menu:

[nmanovic]

Create new task dialog:

• Use color picker icon instead of “Label color”
• The color picker should show the current color

Color picker dialog:

• It should have “OK”, “Cancel” and “Reset” buttons (see Gimp screenshot)

Job view:

• Use “color by” == “label” by default
• Use color picker dialog implemented for create new task dialog
• Use color picker icon to choose a color
• You can choose color only if “color by” equals to “instance” or “group”. Thus “Enter” and “color picker” is enabled only when “color by” != “label”.
• Don't save selected colors on the server

[nmanovic]

I see the code in 3 places. Need to remove code cloning because the logic isn't trivial.

Will Road and road have the same color? Is it OK to have the same color for different classes?

[ActiveChooN]

@nmanovic, sorry for a long wait. Realized that default python hash function has a random seed every run and colors weren't consistent.

I see the code in 3 places. Need to remove code cloning because the logic isn't trivial.

Done.

Will Road and road have the same color? Is it OK to have the same color for different classes?

If that labels will appear in the task only once they will have the same color. But if label will appear in the task more than one time, for the first label color will be taken from the color map and color will be calculated with hash for others.

[bsekachev]

In this patch I can change colors (when Color by set to instance) only using shortcut. UI controls don't work.