-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pino.transport.pipeline
may have lost logs
#1927
Comments
Can you reproduce without pino-syslog? I think the bug is there and not in pino proper. More specifically, pino-syslog does not implement the |
I tried adding a In other words, the thread had already closed before I could do anything https://github.com/pinojs/thread-stream/blob/main/lib/worker.js#L147-L153 |
You linked the logic that catches unhandledRejections.. how is that related? |
Sorry, the link above is incorrect, and in the above text, I mistakenly wrote the |
Please add reproductions. |
thank you for your prompt reply Lines 60 to 67 in c109804
My confusion stems from the fact that once |
The transport functionality I’m aiming to implement is as follows:
like : #318 |
Yes, pino has its logic there to handle that case, while pino-syslog doesn't use it. |
Add autoEnd : false ? Line 38 in c109804
|
I only added pino syslog output
source code: https://github.com/pinojs/pino-syslog/blob/91669fbeb108ae1bb7298d289c2af19001a1fe31/lib/transport.js#L26-L29
This is a screenshot of my test, which shows a probability of losing the log output of
cccccc
there is my versions
TODO
The text was updated successfully, but these errors were encountered: