Bugfix. Switch off quickly all AQO features if queryId is disabled.

One installcheck test was added into the github actions workflow.

Reviewed by: @Anisimov-ds

Author: danolivo

.github/workflows/installchecks.yml

@@ -132,12 +132,24 @@ jobs:
         psql -c "ALTER SYSTEM SET aqo.mode = 'learn'"
         psql -c "ALTER SYSTEM SET aqo.force_collect_stat = 'on'"
         psql -c "SELECT pg_reload_conf()"
-        learn_result=$(make -k installcheck-world)
+        make -k installcheck-world
+
+    # Should work like a total off for all the AQO features
+    - name: installcheck_learn_queryid_off
+      continue-on-error: true
+      run: |
+        cd $PG_DIR
+        aqo_instance_launch.sh
+        psql -c "ALTER SYSTEM SET compute_query_id = 'off'"
+        psql -c "SELECT pg_reload_conf()"
+        # The AQO tests itself wouldn't pass
+        make -k installcheck-world
 
     - name: installcheck_intelligent
       continue-on-error: true
       run: |
         cd $PG_DIR
+        psql -c "ALTER SYSTEM SET compute_query_id = 'regress'"
         psql -c "ALTER SYSTEM SET aqo.mode = 'intelligent'"
         psql -c "ALTER SYSTEM SET aqo.force_collect_stat = 'on'"
         psql -c "SELECT pg_reload_conf()"

preprocessing.c

@@ -83,7 +83,7 @@ static bool isQueryUsingSystemRelation_walker(Node *node, void *context);
 static bool
 aqoIsEnabled(Query *parse)
 {
-	if (creating_extension ||
+	if (creating_extension || !IsQueryIdEnabled() ||
 		(aqo_mode == AQO_MODE_DISABLED && !force_collect_stat) ||
 		(parse->commandType != CMD_SELECT && parse->commandType != CMD_INSERT &&
 		parse->commandType != CMD_UPDATE && parse->commandType != CMD_DELETE))