Correctly drop not comletely constucted index

knizhnik · knizhnik · commit efe3e121f2b1 · 2022-12-06T21:55:18.000+02:00
diff --git a/lsm3.c b/lsm3.c
@@ -971,11 +971,14 @@ lsm3_process_utility(PlannedStmt *plannedStmt,
 					}
 					for (int i = 0; i < 2; i++)
 					{
-						ObjectAddress obj;
-						obj.classId = RelationRelationId;
-						obj.objectId = entry->top[i];
-						obj.objectSubId = 0;
-						add_exact_object_address(&obj, drop_objects);
+						if (entry->top[i])
+						{
+							ObjectAddress obj;
+							obj.classId = RelationRelationId;
+							obj.objectId = entry->top[i];
+							obj.objectSubId = 0;
+							add_exact_object_address(&obj, drop_objects);
+						}
 					}
 					drop_oids = lappend_oid(drop_oids, RelationGetRelid(index));
 				}

Original file line number	Diff line number	Diff line change
`@@ -971,11 +971,14 @@ lsm3_process_utility(PlannedStmt *plannedStmt,`
`971`	`971`	`}`
`972`	`972`	`for (int i = 0; i < 2; i++)`
`973`	`973`	`{`
`974`		`- ObjectAddress obj;`
`975`		`- obj.classId = RelationRelationId;`
`976`		`- obj.objectId = entry->top[i];`
`977`		`- obj.objectSubId = 0;`
`978`		`- add_exact_object_address(&obj, drop_objects);`
	`974`	`+ if (entry->top[i])`
	`975`	`+ {`
	`976`	`+ ObjectAddress obj;`
	`977`	`+ obj.classId = RelationRelationId;`
	`978`	`+ obj.objectId = entry->top[i];`
	`979`	`+ obj.objectSubId = 0;`
	`980`	`+ add_exact_object_address(&obj, drop_objects);`
	`981`	`+ }`
`979`	`982`	`}`
`980`	`983`	`drop_oids = lappend_oid(drop_oids, RelationGetRelid(index));`
`981`	`984`	`}`