code cleansing + refactoring, record AUTO dependency on naming sequence

Author: funbringer

expected/pathman_basic.out

@@ -135,7 +135,6 @@ SELECT pathman.create_range_partitions('test.range_rel', 'dt', '2015-01-01'::DAT
 ERROR:  partitioning key "dt" must be marked NOT NULL
 ALTER TABLE test.range_rel ALTER COLUMN dt SET NOT NULL;
 SELECT pathman.create_range_partitions('test.range_rel', 'DT', '2015-01-01'::DATE, '1 month'::INTERVAL);
-NOTICE:  sequence "range_rel_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        4
@@ -157,7 +156,6 @@ CREATE TABLE test.num_range_rel (
 	id	SERIAL PRIMARY KEY,
 	txt	TEXT);
 SELECT pathman.create_range_partitions('test.num_range_rel', 'id', 0, 1000, 4);
-NOTICE:  sequence "num_range_rel_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        4
@@ -193,7 +191,6 @@ SELECT COUNT(*) FROM ONLY test.num_range_rel;
 CREATE TABLE test.improved_dummy (id BIGSERIAL, name TEXT NOT NULL);
 INSERT INTO test.improved_dummy (name) SELECT md5(g::TEXT) FROM generate_series(1, 100) as g;
 SELECT pathman.create_range_partitions('test.improved_dummy', 'id', 1, 10);
-NOTICE:  sequence "improved_dummy_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                       10
@@ -336,7 +333,6 @@ NOTICE:  drop cascades to 2 other objects
 CREATE TABLE test.insert_into_select(val int NOT NULL);
 INSERT INTO test.insert_into_select SELECT generate_series(1, 100);
 SELECT pathman.create_range_partitions('test.insert_into_select', 'val', 1, 20);
-NOTICE:  sequence "insert_into_select_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        5
@@ -394,7 +390,6 @@ NOTICE:  drop cascades to 5 other objects
 CREATE TABLE test.insert_date_test(val DATE NOT NULL);
 SELECT pathman.create_partitions_from_range('test.insert_date_test', 'val',
 											date '20161001', date '20170101', interval '1 month');
-NOTICE:  sequence "insert_date_test_seq" does not exist, skipping
  create_partitions_from_range 
 ------------------------------
                             4
@@ -1425,7 +1420,6 @@ CREATE TABLE test.zero(
 	value	INT NOT NULL);
 INSERT INTO test.zero SELECT g, g FROM generate_series(1, 100) as g;
 SELECT pathman.create_range_partitions('test.zero', 'value', 50, 10, 0);
-NOTICE:  sequence "zero_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        0
@@ -1754,7 +1748,6 @@ CREATE TABLE test."RangeRel" (
 INSERT INTO test."RangeRel" (dt, txt)
 SELECT g, md5(g::TEXT) FROM generate_series('2015-01-01', '2015-01-03', '1 day'::interval) as g;
 SELECT pathman.create_range_partitions('test."RangeRel"', 'dt', '2015-01-01'::DATE, '1 day'::INTERVAL);
-NOTICE:  sequence "RangeRel_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        3
@@ -2061,7 +2054,6 @@ NOTICE:  drop cascades to 3 other objects
 CREATE TABLE test.special_case_1_ind_o_s(val serial, comment text);
 INSERT INTO test.special_case_1_ind_o_s SELECT generate_series(1, 200), NULL;
 SELECT create_range_partitions('test.special_case_1_ind_o_s', 'val', 1, 50);
-NOTICE:  sequence "special_case_1_ind_o_s_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        4
@@ -2119,7 +2111,6 @@ CREATE TABLE test.index_on_childs(c1 integer not null, c2 integer);
 CREATE INDEX ON test.index_on_childs(c2);
 INSERT INTO test.index_on_childs SELECT i, (random()*10000)::integer FROM generate_series(1, 10000) i;
 SELECT create_range_partitions('test.index_on_childs', 'c1', 1, 1000, 0, false);
-NOTICE:  sequence "index_on_childs_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        0
@@ -2202,6 +2193,6 @@ ORDER BY partition;
 DROP TABLE test.provided_part_names CASCADE;
 NOTICE:  drop cascades to 2 other objects
 DROP SCHEMA test CASCADE;
-NOTICE:  drop cascades to 47 other objects
+NOTICE:  drop cascades to 38 other objects
 DROP EXTENSION pg_pathman CASCADE;
 DROP SCHEMA pathman CASCADE;

expected/pathman_bgw.out

@@ -8,7 +8,6 @@ CREATE SCHEMA test_bgw;
 /* int4, size of Datum == 4 */
 CREATE TABLE test_bgw.test_1(val INT4 NOT NULL);
 SELECT create_range_partitions('test_bgw.test_1', 'val', 1, 5, 2);
-NOTICE:  sequence "test_1_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        2
@@ -34,7 +33,6 @@ NOTICE:  drop cascades to 3 other objects
 /* int8, size of Datum == 8 */
 CREATE TABLE test_bgw.test_2(val INT8 NOT NULL);
 SELECT create_range_partitions('test_bgw.test_2', 'val', 1, 5, 2);
-NOTICE:  sequence "test_2_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        2
@@ -60,7 +58,6 @@ NOTICE:  drop cascades to 3 other objects
 /* numeric, size of Datum == var */
 CREATE TABLE test_bgw.test_3(val NUMERIC NOT NULL);
 SELECT create_range_partitions('test_bgw.test_3', 'val', 1, 5, 2);
-NOTICE:  sequence "test_3_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        2
@@ -86,7 +83,6 @@ NOTICE:  drop cascades to 3 other objects
 /* date, size of Datum == var */
 CREATE TABLE test_bgw.test_4(val DATE NOT NULL);
 SELECT create_range_partitions('test_bgw.test_4', 'val', '20170213'::date, '1 day'::interval, 2);
-NOTICE:  sequence "test_4_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        2
@@ -110,5 +106,4 @@ SELECT * FROM pathman_partition_list ORDER BY partition; /* should contain 3 par
 DROP TABLE test_bgw.test_4 CASCADE;
 NOTICE:  drop cascades to 3 other objects
 DROP SCHEMA test_bgw CASCADE;
-NOTICE:  drop cascades to 4 other objects
 DROP EXTENSION pg_pathman;

expected/pathman_calamity.out

@@ -21,7 +21,6 @@ CREATE TABLE calamity.part_test(val serial);
 /* test pg_pathman's cache */
 INSERT INTO calamity.part_test SELECT generate_series(1, 30);
 SELECT create_range_partitions('calamity.part_test', 'val', 1, 10);
-NOTICE:  sequence "part_test_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        3
@@ -704,7 +703,6 @@ SELECT count(*) FROM pathman_config_params WHERE partrel = 'calamity.to_be_disab
 /* check function get_part_range_by_idx() */
 CREATE TABLE calamity.test_range_idx(val INT4 NOT NULL);
 SELECT create_range_partitions('calamity.test_range_idx', 'val', 1, 10, 1);
-NOTICE:  sequence "test_range_idx_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        1
@@ -731,7 +729,6 @@ NOTICE:  drop cascades to table calamity.test_range_idx_1
 /* check function get_part_range_by_oid() */
 CREATE TABLE calamity.test_range_oid(val INT4 NOT NULL);
 SELECT create_range_partitions('calamity.test_range_oid', 'val', 1, 10, 1);
-NOTICE:  sequence "test_range_oid_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        1
@@ -759,14 +756,12 @@ ERROR:  cannot merge partitions
 CREATE TABLE calamity.merge_test_a(val INT4 NOT NULL);
 CREATE TABLE calamity.merge_test_b(val INT4 NOT NULL);
 SELECT create_range_partitions('calamity.merge_test_a', 'val', 1, 10, 2);
-NOTICE:  sequence "merge_test_a_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        2
 (1 row)
 
 SELECT create_range_partitions('calamity.merge_test_b', 'val', 1, 10, 2);
-NOTICE:  sequence "merge_test_b_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        2
@@ -824,7 +819,7 @@ SELECT count(*) FROM pg_trigger WHERE tgrelid = 'calamity.trig_test_tbl_1'::REGC
 DROP TABLE calamity.trig_test_tbl CASCADE;
 NOTICE:  drop cascades to 2 other objects
 DROP SCHEMA calamity CASCADE;
-NOTICE:  drop cascades to 20 other objects
+NOTICE:  drop cascades to 15 other objects
 DROP EXTENSION pg_pathman;
 /*
  * -------------------------------------
@@ -838,7 +833,6 @@ SET pg_pathman.enable_bounds_cache = false;
 /* check view pathman_cache_stats */
 CREATE TABLE calamity.test_pathman_cache_stats(val NUMERIC NOT NULL);
 SELECT create_range_partitions('calamity.test_pathman_cache_stats', 'val', 1, 10, 10);
-NOTICE:  sequence "test_pathman_cache_stats_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                       10
@@ -925,7 +919,6 @@ SELECT context, entries FROM pathman_cache_stats ORDER BY context;	/* OK */
 
 DROP TABLE calamity.test_pathman_cache_stats;
 DROP SCHEMA calamity CASCADE;
-NOTICE:  drop cascades to sequence calamity.test_pathman_cache_stats_seq
 DROP EXTENSION pg_pathman;
 /*
  * ------------------------------------------
@@ -937,7 +930,6 @@ CREATE EXTENSION pg_pathman;
 /* check function pathman_cache_search_relid() */
 CREATE TABLE calamity.survivor(val INT NOT NULL);
 SELECT create_range_partitions('calamity.survivor', 'val', 1, 10, 2);
-NOTICE:  sequence "survivor_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        2
@@ -1000,5 +992,4 @@ EXPLAIN (COSTS OFF) SELECT * FROM calamity.survivor;			/* OK */
 DROP TABLE calamity.survivor CASCADE;
 NOTICE:  drop cascades to 2 other objects
 DROP SCHEMA calamity CASCADE;
-NOTICE:  drop cascades to sequence calamity.survivor_seq
 DROP EXTENSION pg_pathman;

expected/pathman_callbacks.out

@@ -16,7 +16,6 @@ END
 $$ language plpgsql;
 CREATE TABLE callbacks.abc(a serial, b int);
 SELECT create_range_partitions('callbacks.abc', 'a', 1, 100, 2);
-NOTICE:  sequence "abc_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        2
@@ -416,5 +415,5 @@ ORDER BY range_min::INT4;
 DROP TABLE callbacks.abc CASCADE;
 NOTICE:  drop cascades to 4 other objects
 DROP SCHEMA callbacks CASCADE;
-NOTICE:  drop cascades to 3 other objects
+NOTICE:  drop cascades to 2 other objects
 DROP EXTENSION pg_pathman CASCADE;

expected/pathman_column_type.out

@@ -8,7 +8,6 @@ CREATE SCHEMA test_column_type;
 /* create new table (val int) */
 CREATE TABLE test_column_type.test(val INT4 NOT NULL);
 SELECT create_range_partitions('test_column_type.test', 'val', 1, 10, 10);
-NOTICE:  sequence "test_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                       10
@@ -167,5 +166,4 @@ NOTICE:  0 rows copied from test_column_type.test_4
 
 DROP TABLE test_column_type.test CASCADE;
 DROP SCHEMA test_column_type CASCADE;
-NOTICE:  drop cascades to sequence test_column_type.test_seq
 DROP EXTENSION pg_pathman;

expected/pathman_cte.out

@@ -13,7 +13,6 @@ INSERT INTO test_cte.range_rel (dt, txt)
 SELECT g, md5(g::TEXT)
 FROM generate_series('2015-01-01', '2015-04-30', '1 day'::interval) AS g;
 SELECT create_range_partitions('test_cte.range_rel', 'DT', '2015-01-01'::DATE, '1 month'::INTERVAL);
-NOTICE:  sequence "range_rel_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        4
@@ -80,7 +79,6 @@ INSERT INTO test_cte.cte_del_xacts_specdata VALUES (1, 1, 1, current_timestamp);
 /* create 2 partitions */
 SELECT create_range_partitions('test_cte.cte_del_xacts'::regclass, 'pdate',
 							   '2016-01-01'::date, '50 days'::interval);
-NOTICE:  sequence "cte_del_xacts_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        2
@@ -270,5 +268,5 @@ SELECT * FROM test;
 (4 rows)
 
 DROP SCHEMA test_cte CASCADE;
-NOTICE:  drop cascades to 5 other objects
+NOTICE:  drop cascades to 3 other objects
 DROP EXTENSION pg_pathman;

expected/pathman_domains.out

@@ -5,7 +5,6 @@ CREATE DOMAIN domains.dom_test AS numeric CHECK (value < 1200);
 CREATE TABLE domains.dom_table(val domains.dom_test NOT NULL);
 INSERT INTO domains.dom_table SELECT generate_series(1, 999);
 SELECT create_range_partitions('domains.dom_table', 'val', 1, 100);
-NOTICE:  sequence "dom_table_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                       10
@@ -125,5 +124,5 @@ ORDER BY "partition"::TEXT;
 (5 rows)
 
 DROP SCHEMA domains CASCADE;
-NOTICE:  drop cascades to 8 other objects
+NOTICE:  drop cascades to 7 other objects
 DROP EXTENSION pg_pathman CASCADE;

expected/pathman_expressions.out

@@ -78,7 +78,6 @@ SELECT create_range_partitions('test_exprs.range_rel', 'RANDOM()', '15 years'::I
 ERROR:  start value is less than min value of "random()"
 SELECT create_range_partitions('test_exprs.range_rel', 'AGE(dt, ''2000-01-01''::DATE)',
 		'15 years'::INTERVAL, '1 year'::INTERVAL, 10);
-NOTICE:  sequence "range_rel_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                       10
@@ -152,5 +151,5 @@ SELECT COUNT(*) FROM test_exprs.range_rel_2;
 (1 row)
 
 DROP SCHEMA test_exprs CASCADE;
-NOTICE:  drop cascades to 17 other objects
+NOTICE:  drop cascades to 16 other objects
 DROP EXTENSION pg_pathman;

expected/pathman_foreign_keys.out

@@ -10,7 +10,6 @@ CREATE TABLE fkeys.test_fkey(
 	FOREIGN KEY (comment) REFERENCES fkeys.test_ref(comment));
 INSERT INTO fkeys.test_fkey SELECT generate_series(1, 1000), 'test';
 SELECT create_range_partitions('fkeys.test_fkey', 'id', 1, 100);
-NOTICE:  sequence "test_fkey_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                       10
@@ -75,7 +74,6 @@ WARNING:  foreign key "replies_message_id_fkey" references table "fkeys.messages
 ERROR:  table "fkeys.messages" is referenced from other tables
 ALTER TABLE fkeys.replies DROP CONSTRAINT replies_message_id_fkey;
 SELECT create_range_partitions('fkeys.messages', 'id', 1, 100, 2); /* ok */
-NOTICE:  sequence "messages_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        2
@@ -92,5 +90,5 @@ EXPLAIN (COSTS OFF) SELECT * FROM fkeys.messages;
 DROP TABLE fkeys.messages, fkeys.replies CASCADE;
 NOTICE:  drop cascades to 2 other objects
 DROP SCHEMA fkeys CASCADE;
-NOTICE:  drop cascades to 4 other objects
+NOTICE:  drop cascades to 2 other objects
 DROP EXTENSION pg_pathman CASCADE;

expected/pathman_inserts.out

@@ -7,7 +7,6 @@ CREATE TABLE test_inserts.storage(a INT4, b INT4 NOT NULL, c NUMERIC, d TEXT);
 INSERT INTO test_inserts.storage SELECT i * 2, i, i, i::text FROM generate_series(1, 100) i;
 CREATE UNIQUE INDEX ON test_inserts.storage(a);
 SELECT create_range_partitions('test_inserts.storage', 'b', 1, 10);
-NOTICE:  sequence "storage_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                       10
@@ -858,7 +857,6 @@ NOTICE:  AFTER INSERTION TRIGGER ON TABLE storage_14 HAS EXPIRED. INSERTED ROW:
 CREATE TABLE test_inserts.test_gap(val INT NOT NULL);
 INSERT INTO test_inserts.test_gap SELECT generate_series(1, 30);
 SELECT create_range_partitions('test_inserts.test_gap', 'val', 1, 10);
-NOTICE:  sequence "test_gap_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        3
@@ -870,5 +868,5 @@ ERROR:  cannot spawn a partition
 DROP TABLE test_inserts.test_gap CASCADE;
 NOTICE:  drop cascades to 2 other objects
 DROP SCHEMA test_inserts CASCADE;
-NOTICE:  drop cascades to 20 other objects
+NOTICE:  drop cascades to 18 other objects
 DROP EXTENSION pg_pathman CASCADE;

expected/pathman_interval.out

@@ -4,7 +4,6 @@ CREATE SCHEMA test_interval;
 /* Range partitions for INT2 type */
 CREATE TABLE test_interval.abc (id INT2 NOT NULL);
 SELECT create_range_partitions('test_interval.abc', 'id', 0, 100, 2);
-NOTICE:  sequence "abc_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        2
@@ -272,5 +271,4 @@ ERROR:  table "test_interval.abc" is not partitioned by RANGE
 DROP TABLE test_interval.abc CASCADE;
 NOTICE:  drop cascades to 3 other objects
 DROP SCHEMA test_interval CASCADE;
-NOTICE:  drop cascades to sequence test_interval.abc_seq
 DROP EXTENSION pg_pathman;

expected/pathman_only.out

@@ -11,7 +11,6 @@ CREATE SCHEMA test_only;
 CREATE TABLE test_only.from_only_test(val INT NOT NULL);
 INSERT INTO test_only.from_only_test SELECT generate_series(1, 20);
 SELECT create_range_partitions('test_only.from_only_test', 'val', 1, 2);
-NOTICE:  sequence "from_only_test_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                       10
@@ -239,5 +238,5 @@ WHERE val = (SELECT val FROM ONLY test_only.from_only_test
 (27 rows)
 
 DROP SCHEMA test_only CASCADE;
-NOTICE:  drop cascades to 12 other objects
+NOTICE:  drop cascades to 11 other objects
 DROP EXTENSION pg_pathman;

expected/pathman_permissions.out

@@ -23,7 +23,6 @@ ERROR:  only the owner or superuser can change partitioning configuration of tab
 /* Should be ok */
 SET ROLE user1;
 SELECT create_range_partitions('permissions.user1_table', 'id', 1, 10, 2);
-NOTICE:  sequence "user1_table_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        2
@@ -169,7 +168,6 @@ CREATE TABLE permissions.dropped_column(a int, val int not null, b int, c int);
 INSERT INTO permissions.dropped_column SELECT i,i,i,i FROM generate_series(1, 30) i;
 GRANT SELECT(val), INSERT(val) ON permissions.dropped_column TO user2;
 SELECT create_range_partitions('permissions.dropped_column', 'val', 1, 10);
-NOTICE:  sequence "dropped_column_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        3

expected/pathman_runtime_nodes.out

@@ -263,7 +263,6 @@ create index on test.runtime_test_3_0 (id);
 create table test.runtime_test_4(val text, id int not null);
 insert into test.runtime_test_4(id, val) select * from generate_series(1, 10000) k, md5(k::text);
 select pathman.create_range_partitions('test.runtime_test_4', 'id', 1, 2000);
-NOTICE:  sequence "runtime_test_4_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                        5
@@ -409,6 +408,6 @@ where id = any (select generate_series(-10, -1)); /* should be empty */
 set enable_hashjoin = on;
 set enable_mergejoin = on;
 DROP SCHEMA test CASCADE;
-NOTICE:  drop cascades to 37 other objects
+NOTICE:  drop cascades to 36 other objects
 DROP EXTENSION pg_pathman CASCADE;
 DROP SCHEMA pathman CASCADE;

expected/pathman_update_trigger.out

@@ -6,7 +6,6 @@ CREATE SCHEMA test_update_trigger;
 CREATE TABLE test_update_trigger.test_range(val NUMERIC NOT NULL, comment TEXT);
 INSERT INTO test_update_trigger.test_range SELECT i, i FROM generate_series(1, 100) i;
 SELECT create_range_partitions('test_update_trigger.test_range', 'val', 1, 10);
-NOTICE:  sequence "test_range_seq" does not exist, skipping
  create_range_partitions 
 -------------------------
                       10
@@ -286,5 +285,5 @@ SELECT count(*) FROM test_update_trigger.test_hash;
 (1 row)
 
 DROP SCHEMA test_update_trigger CASCADE;
-NOTICE:  drop cascades to 18 other objects
+NOTICE:  drop cascades to 17 other objects
 DROP EXTENSION pg_pathman;