PGPRO-8546: Create targetlist in partition filter and partition router nodes right with the parent_rti indexes.

In accordance with the pointing of Tom Lane:
https://www.postgresql.org/message-id/71315.1686243488%40sss.pgh.pa.us

Tags: pg_pathman

Author: antamel

src/include/partition_filter.h

@@ -181,9 +181,7 @@ TupleConversionMap * build_part_tuple_map_child(Relation child_rel);
 
 void destroy_tuple_map(TupleConversionMap *tuple_map);
 
-List * pfilter_build_tlist(Plan *subplan);
-
-void pfilter_tlist_fix_resjunk(CustomScan *subplan);
+List * pfilter_build_tlist(Plan *subplan, Index varno);
 
 /* Find suitable partition using 'value' */
 Oid * find_partitions_for_value(Datum value, Oid value_type,

src/partition_filter.c

@@ -812,12 +812,7 @@ make_partition_filter(Plan *subplan,
 	cscan->scan.scanrelid = 0;
 
 	/* Build an appropriate target list */
-	cscan->scan.plan.targetlist = pfilter_build_tlist(subplan);
-
-	/* Prepare 'custom_scan_tlist' for EXPLAIN (VERBOSE) */
-	cscan->custom_scan_tlist = copyObject(cscan->scan.plan.targetlist);
-	ChangeVarNodes((Node *) cscan->custom_scan_tlist, INDEX_VAR, parent_rti, 0);
-	pfilter_tlist_fix_resjunk(cscan);
+	cscan->scan.plan.targetlist = pfilter_build_tlist(subplan, parent_rti);
 
 	/* Pack partitioned table's Oid and conflict_action */
 	cscan->custom_private = list_make4(makeInteger(parent_relid),
@@ -1076,7 +1071,7 @@ partition_filter_explain(CustomScanState *node, List *ancestors, ExplainState *e
  * Build partition filter's target list pointing to subplan tuple's elements.
  */
 List *
-pfilter_build_tlist(Plan *subplan)
+pfilter_build_tlist(Plan *subplan, Index varno)
 {
 	List	   *result_tlist = NIL;
 	ListCell   *lc;
@@ -1096,7 +1091,7 @@ pfilter_build_tlist(Plan *subplan)
 		}
 		else
 		{
-			Var *var = makeVar(INDEX_VAR,	/* point to subplan's elements */
+			Var *var = makeVar(varno,	/* point to subplan's elements */
 							   tle->resno,
 							   exprType((Node *) tle->expr),
 							   exprTypmod((Node *) tle->expr),
@@ -1115,34 +1110,6 @@ pfilter_build_tlist(Plan *subplan)
 	return result_tlist;
 }
 
-/*
- * resjunk Vars had its varattnos being set on nonexisting relation columns.
- * For future processing service attributes should be indicated correctly.
- */
-void
-pfilter_tlist_fix_resjunk(CustomScan *css)
-{
-	ListCell *lc;
-
-	foreach(lc, css->custom_scan_tlist)
-	{
-		TargetEntry *tle = (TargetEntry *) lfirst(lc);
-
-		if (!IsA(tle->expr, Const))
-		{
-			Var *var = (Var *) tle->expr;
-
-			if (tle->resjunk)
-			{
-				/* To make Var recognizable as service attribute. */
-				var->varattno = -1;
-			}
-		}
-	}
-
-	return;
-}
-
 /*
  * ----------------------------------------------
  *  Additional init steps for ResultPartsStorage

src/partition_overseer.c

@@ -46,7 +46,7 @@ make_partition_overseer(Plan *subplan)
 	cscan->scan.scanrelid = 0;
 
 	/* Build an appropriate target list */
-	cscan->scan.plan.targetlist = pfilter_build_tlist(subplan);
+	cscan->scan.plan.targetlist = pfilter_build_tlist(subplan, INDEX_VAR);
 	cscan->custom_scan_tlist = subplan->targetlist;
 
 	return &cscan->scan.plan;

src/partition_router.c

@@ -134,12 +134,7 @@ make_partition_router(Plan *subplan, int epq_param, Index parent_rti)
 	cscan->scan.scanrelid = 0;
 
 	/* Build an appropriate target list */
-	cscan->scan.plan.targetlist = pfilter_build_tlist(subplan);
-
-	/* Fix 'custom_scan_tlist' for EXPLAIN (VERBOSE) */
-	cscan->custom_scan_tlist = copyObject(cscan->scan.plan.targetlist);
-	ChangeVarNodes((Node *) cscan->custom_scan_tlist, INDEX_VAR, parent_rti, 0);
-	pfilter_tlist_fix_resjunk(cscan);
+	cscan->scan.plan.targetlist = pfilter_build_tlist(subplan, parent_rti);
 
 	return &cscan->scan.plan;
 }