Fix dead assignments & some other issues reported by clang-analyzer, update gitignore

Author: funbringer

.gitignore

@@ -1,4 +1,7 @@
 .deps
+results/pg_pathman.out
+regression.diffs
+regression.out
 *.o
 *.so
-pg_pathman--*.sql
+pg_pathman--*.sql

dsm_array.c

@@ -290,7 +290,7 @@ resize_dsm_array(DsmArray *arr, size_t entry_size, size_t length)
 }
 
 void *
-dsm_array_get_pointer(const DsmArray* arr)
+dsm_array_get_pointer(const DsmArray *arr)
 {
 	return (char *) dsm_segment_address(segment) + arr->offset + sizeof(BlockHeader);
 }

pl_funcs.c

@@ -159,11 +159,6 @@ find_or_create_range_partition(PG_FUNCTION_ARGS)
 		/* Start background worker to create new partitions */
 		child_oid = create_partitions_bg_worker(relid, value, value_type, &crashed);
 
-		// SPI_connect();
-		// child_oid = create_partitions(relid, value, value_type, &crashed);
-		// SPI_finish();
-		// elog(WARNING, "Worker finished");
-
 		/* Release locks */
 		if (!crashed)
 		{
@@ -172,8 +167,7 @@ find_or_create_range_partition(PG_FUNCTION_ARGS)
 		}
 
 		/* Repeat binary search */
-		ranges = dsm_array_get_pointer(&rangerel->ranges);
-		pos = range_binary_search(rangerel, &cmp_func, value, &found);
+		(void) range_binary_search(rangerel, &cmp_func, value, &found);
 		if (found)
 			PG_RETURN_OID(child_oid);
 	}

worker.c

@@ -99,6 +99,12 @@ create_partitions_bg_worker(Oid relid, Datum value, Oid value_type, bool *crashe
 
 	/* Wait till the worker finishes its job */
 	status = WaitForBackgroundWorkerShutdown(worker_handle);
+	if (status == BGWH_POSTMASTER_DIED)
+	{
+		ereport(WARNING,
+                (errmsg("Postmaster died during the pg_pathman background worker process"),
+                 errhint("More details may be available in the server log.")));
+	}
 	*crashed = args->crashed;
 	child_oid = args->result;
 
@@ -170,7 +176,6 @@ create_partitions(Oid relid, Datum value, Oid value_type, bool *crashed)
 
 	prel = get_pathman_relation_info(relid, NULL);
 	rangerel = get_pathman_range_relation(relid, NULL);
-	ranges = dsm_array_get_pointer(&rangerel->ranges);
 
 	/* Comparison function */
 	cmp_func = *get_cmp_func(value_type, prel->atttype);