Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 0153c4c

Browse files
committed
Be less wishy-washy in the documentation and comments about whether a
ParameterStatus message can be sent during COPY OUT: it's definitely possible, since COPY from a SELECT subquery can trigger any user-defined function.
1 parent 14e2a26 commit 0153c4c

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

doc/src/sgml/protocol.sgml

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<!-- $PostgreSQL: pgsql/doc/src/sgml/protocol.sgml,v 1.71 2008/01/14 18:46:17 tgl Exp $ -->
1+
<!-- $PostgreSQL: pgsql/doc/src/sgml/protocol.sgml,v 1.72 2008/01/15 22:18:20 tgl Exp $ -->
22

33
<chapter id="protocol">
44
<title>Frontend/Backend Protocol</title>
@@ -1044,10 +1044,10 @@
10441044
</para>
10451045

10461046
<para>
1047-
It is possible for NoticeResponse messages to be interspersed between
1048-
CopyData messages; frontends must handle this case, and should be
1049-
prepared for other asynchronous message types as well (see <xref
1050-
linkend="protocol-async">). Otherwise, any message type other than
1047+
It is possible for NoticeResponse and ParameterStatus messages to be
1048+
interspersed between CopyData messages; frontends must handle these cases,
1049+
and should be prepared for other asynchronous message types as well (see
1050+
<xref linkend="protocol-async">). Otherwise, any message type other than
10511051
CopyData or CopyDone may be treated as terminating copy-out mode.
10521052
</para>
10531053

src/interfaces/libpq/fe-protocol3.c

+3-4
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $PostgreSQL: pgsql/src/interfaces/libpq/fe-protocol3.c,v 1.32 2008/01/14 18:46:17 tgl Exp $
11+
* $PostgreSQL: pgsql/src/interfaces/libpq/fe-protocol3.c,v 1.33 2008/01/15 22:18:20 tgl Exp $
1212
*
1313
*-------------------------------------------------------------------------
1414
*/
@@ -1310,9 +1310,8 @@ getCopyDataMessage(PGconn *conn)
13101310
/*
13111311
* If it's a legitimate async message type, process it. (NOTIFY
13121312
* messages are not currently possible here, but we handle them for
1313-
* completeness. NOTICE is definitely possible, and ParameterStatus
1314-
* could probably be made to happen.) Otherwise, if it's anything
1315-
* except Copy Data, report end-of-copy.
1313+
* completeness.) Otherwise, if it's anything except Copy Data,
1314+
* report end-of-copy.
13161315
*/
13171316
switch (id)
13181317
{

0 commit comments

Comments
 (0)