Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 02ba72e

Browse files
committed
Fix incorrect close() call in dsm_impl_mmap().
One improbable error-exit path in this function used close() where it should have used CloseTransientFile(). This is unlikely to be hit in the field, and I think the consequences wouldn't be awful (just an elog(LOG) bleat later). But a bug is a bug, so back-patch to 9.4 where this code came in. Pan Bian Discussion: https://postgr.es/m/152056616579.4966.583293218357089052@wrigleys.postgresql.org
1 parent 29ab156 commit 02ba72e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/backend/storage/ipc/dsm_impl.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -923,7 +923,7 @@ dsm_impl_mmap(dsm_op op, dsm_handle handle, Size request_size,
923923

924924
/* Back out what's already been done. */
925925
save_errno = errno;
926-
close(fd);
926+
CloseTransientFile(fd);
927927
if (op == DSM_OP_CREATE)
928928
unlink(name);
929929
errno = save_errno;

0 commit comments

Comments
 (0)