Extract jsonb_sel_internal() from jsonb_sel()

Author: Nikita Glukhov

src/backend/utils/adt/jsonb_selfuncs.c

@@ -1307,50 +1307,16 @@ jsonSelectivityExists(JsonStats stats, Datum key)
 	return sel;
 }
 
-/*
- * jsonb_sel
- *		The main procedure estimating selectivity for all JSONB operators.
- */
-Datum
-jsonb_sel(PG_FUNCTION_ARGS)
+static Selectivity
+jsonb_sel_internal(JsonStats stats, Oid operator, Const *cnst, bool varonleft)
 {
-	PlannerInfo *root = (PlannerInfo *) PG_GETARG_POINTER(0);
-	Oid			operator = PG_GETARG_OID(1);
-	List	   *args = (List *) PG_GETARG_POINTER(2);
-	int			varRelid = PG_GETARG_INT32(3);
-	double		sel = DEFAULT_JSON_CONTAINS_SEL;
-	Node	   *other;
-	Const	   *cnst;
-	bool		varonleft;
-	JsonStatData stats;
-	VariableStatData vardata;
-
-	if (!get_restriction_variable(root, args, varRelid,
-								  &vardata, &other, &varonleft))
-		PG_RETURN_FLOAT8(sel);
-
-	if (!IsA(other, Const))
-		goto out;
-
-	cnst = (Const *) other;
-
-	if (cnst->constisnull)
-	{
-		sel = 0.0;
-		goto out;
-	}
-
-	if (!jsonStatsInit(&stats, &vardata))
-		goto out;
-
 	switch (operator)
 	{
 		case JsonbExistsOperator:
 			if (!varonleft || cnst->consttype != TEXTOID)
-				goto out;
+				break;
 
-			sel = jsonSelectivityExists(&stats, cnst->constvalue);
-			break;
+			return jsonSelectivityExists(stats, cnst->constvalue);
 
 		case JsonbExistsAnyOperator:
 		case JsonbExistsAllOperator:
@@ -1363,15 +1329,15 @@ jsonb_sel(PG_FUNCTION_ARGS)
 			bool		all = operator == JsonbExistsAllOperator;
 
 			if (!varonleft || cnst->consttype != TEXTARRAYOID)
-				goto out;
+				break;
 
 			deconstruct_array(DatumGetArrayTypeP(cnst->constvalue), TEXTOID,
 							  -1, false, 'i', &keys, &nulls, &nkeys);
 
 			for (i = 0; i < nkeys; i++)
 				if (!nulls[i])
 				{
-					Selectivity pathfreq = jsonSelectivityExists(&stats,
+					Selectivity pathfreq = jsonSelectivityExists(stats,
 																 keys[i]);
 					freq *= all ? pathfreq : (1.0 - pathfreq);
 				}
@@ -1382,30 +1348,69 @@ jsonb_sel(PG_FUNCTION_ARGS)
 			if (!all)
 				freq = 1.0 - freq;
 
-			sel = freq;
-			break;
+			return freq;
 		}
 
 		case JsonbContainedOperator:
 			if (varonleft || cnst->consttype != JSONBOID)
-				goto out;
+				break;
 
-			sel = jsonSelectivityContains(&stats,
-										  DatumGetJsonbP(cnst->constvalue));
-			break;
+			return jsonSelectivityContains(stats,
+										   DatumGetJsonbP(cnst->constvalue));
 
 		case JsonbContainsOperator:
 			if (!varonleft || cnst->consttype != JSONBOID)
-				goto out;
+				break;
 
-			sel = jsonSelectivityContains(&stats,
-										  DatumGetJsonbP(cnst->constvalue));
+			return jsonSelectivityContains(stats,
+										   DatumGetJsonbP(cnst->constvalue));
+
+		default:
 			break;
 	}
 
-out:
-	jsonStatsRelease(&stats);
-	ReleaseVariableStats(vardata);
+	return DEFAULT_JSON_CONTAINS_SEL;
+}
+
+/*
+ * jsonb_sel
+ *		The main procedure estimating selectivity for all JSONB operators.
+ */
+Datum
+jsonb_sel(PG_FUNCTION_ARGS)
+{
+	PlannerInfo *root = (PlannerInfo *) PG_GETARG_POINTER(0);
+	Oid			operator = PG_GETARG_OID(1);
+	List	   *args = (List *) PG_GETARG_POINTER(2);
+	int			varRelid = PG_GETARG_INT32(3);
+	double		sel = DEFAULT_JSON_CONTAINS_SEL;
+	Node	   *other;
+	bool		varonleft;
+	VariableStatData vardata;
+
+	if (get_restriction_variable(root, args, varRelid,
+								  &vardata, &other, &varonleft))
+	{
+		if (IsA(other, Const))
+		{
+			Const	   *cnst = (Const *) other;
+
+			if (cnst->constisnull)
+				sel = 0.0;
+			else
+			{
+				JsonStatData stats;
+
+				if (jsonStatsInit(&stats, &vardata))
+				{
+					sel = jsonb_sel_internal(&stats, operator, cnst, varonleft);
+					jsonStatsRelease(&stats);
+				}
+			}
+		}
+
+		ReleaseVariableStats(vardata);
+	}
 
 	PG_RETURN_FLOAT8((float8) sel);
 }