Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 05a304a

Browse files
Make SP-GiST redirect cleanup more aggressive.
Commit 61b313e made VACUUM pass down a heaprel to index AM bulkdelete and vacuumcleanup routines. Although this was primarily intended as preparation for logical decoding on standbys, it also made it easy to correct an old deficiency in how we determine how to cleanup SP-GiST redirect and placeholder tuples. Pass the heaprel to GlobalVisTestFor() during cleanup of redirect and placeholder tuples, rather than pessimistically passing NULL. Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Discussion: https://postgr.es/m/02392033-f030-a3c8-c7d0-5c27eb529fec@gmail.com
1 parent e48c817 commit 05a304a

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/backend/access/spgist/spgvacuum.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -507,8 +507,7 @@ vacuumRedirectAndPlaceholder(Relation index, Relation heaprel, Buffer buffer)
507507
xlrec.nToPlaceholder = 0;
508508
xlrec.snapshotConflictHorizon = InvalidTransactionId;
509509

510-
/* XXX: providing heap relation would allow more pruning */
511-
vistest = GlobalVisTestFor(NULL);
510+
vistest = GlobalVisTestFor(heaprel);
512511

513512
START_CRIT_SECTION();
514513

0 commit comments

Comments
 (0)