Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 061cc7e

Browse files
committed
Remove some comments related to pqPipelineSync() and PQsendPipelineSync()
These comments explained how these functions behave internally, and the equivalent is described in the documentation section dedicated to the pipeline mode of libpq. Let's remove these comments, getting rid of the duplication with the docs. Reported-by: Álvaro Herrera Reviewed-by: Álvaro Herrera Discussion: https://postgr.es/m/202401150949.wq7ynlmqxphy@alvherre.pgsql
1 parent 2197d06 commit 061cc7e

File tree

1 file changed

+0
-17
lines changed

1 file changed

+0
-17
lines changed

src/interfaces/libpq/fe-exec.c

-17
Original file line numberDiff line numberDiff line change
@@ -3247,23 +3247,6 @@ PQsendPipelineSync(PGconn *conn)
32473247
/*
32483248
* Workhorse function for PQpipelineSync and PQsendPipelineSync.
32493249
*
3250-
* It's legal to start submitting more commands in the pipeline immediately,
3251-
* without waiting for the results of the current pipeline. There's no need to
3252-
* end pipeline mode and start it again.
3253-
*
3254-
* If a command in a pipeline fails, every subsequent command up to and
3255-
* including the result to the Sync message sent by pqPipelineSyncInternal
3256-
* gets set to PGRES_PIPELINE_ABORTED state. If the whole pipeline is
3257-
* processed without error, a PGresult with PGRES_PIPELINE_SYNC is produced.
3258-
*
3259-
* Queries can already have been sent before pqPipelineSyncInternal is called,
3260-
* but pqPipelineSyncInternal needs to be called before retrieving command
3261-
* results.
3262-
*
3263-
* The connection will remain in pipeline mode and unavailable for new
3264-
* synchronous command execution functions until all results from the pipeline
3265-
* are processed by the client.
3266-
*
32673250
* immediate_flush controls if the flush happens immediately after sending the
32683251
* Sync message or not.
32693252
*/

0 commit comments

Comments
 (0)