Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 066e8ac

Browse files
committed
Use xmlAddChildList not xmlAddChild in XMLSERIALIZE.
It looks like we should have been doing this all along, but we got away with the wrong coding until libxml2 2.13.0 tightened up xmlAddChild's behavior. There is more stuff to be fixed to be compatible with 2.13.0, and it will all need to be back-patched. This is just a trial commit to see if the buildfarm agrees that we can use xmlAddChildList unconditionally. Erik Wienhold, per report from Frank Streitzig. Discussion: https://postgr.es/m/trinity-b0161630-d230-4598-9ebc-7a23acdb37cb-1720186432160@3c-app-gmx-bap25 Discussion: https://postgr.es/m/trinity-361ba18b-541a-4fe7-bc63-655ae3a7d599-1720259822452@3c-app-gmx-bs01
1 parent 04bcf9e commit 066e8ac

File tree

1 file changed

+1
-1
lines changed
  • src/backend/utils/adt

1 file changed

+1
-1
lines changed

src/backend/utils/adt/xml.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -757,7 +757,7 @@ xmltotext_with_options(xmltype *data, XmlOptionType xmloption_arg, bool indent)
757757

758758
/* This attaches root to doc, so we need not free it separately. */
759759
xmlDocSetRootElement(doc, root);
760-
xmlAddChild(root, content_nodes);
760+
xmlAddChildList(root, content_nodes);
761761

762762
/*
763763
* We use this node to insert newlines in the dump. Note: in at

0 commit comments

Comments
 (0)