Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 06be01e

Browse files
committed
Fix instable 006_login_trigger.pl test
Handling of login trigger FATAL error could cause a timing-dependant panic of IPC::Run. This commit excludes checks which involves handling of such errors. Reported-by: Tom Lane Discussion: https://postgr.es/m/2268825.1698618066%40sss.pgh.pa.us
1 parent 5ba4cc3 commit 06be01e

File tree

1 file changed

+3
-14
lines changed

1 file changed

+3
-14
lines changed

src/test/authentication/t/006_login_trigger.pl

+3-14
Original file line numberDiff line numberDiff line change
@@ -143,27 +143,16 @@ BEGIN
143143
log_exact => '2',
144144
err_like => [qr/You are welcome/]);
145145

146-
# Try to log as allowed Alice and disallowed Mallory (two times)
146+
# Try to login as allowed Alice. We don't check the Mallroy login, because
147+
# FATAL error could cause a timing-dependant panic of IPC::Run.
147148
psql_command(
148149
$node, 'SELECT 1;', 0, 'try regress_alice',
149150
connstr => 'user=regress_alice',
150151
log_exact => '1',
151152
err_like => [qr/You are welcome/],
152153
err_unlike => [qr/You are NOT welcome/]);
153-
psql_command(
154-
$node, 'SELECT 1;', 2, 'try regress_mallory',
155-
connstr => 'user=regress_mallory',
156-
log_exact => '',
157-
err_like => [qr/You are NOT welcome/],
158-
err_unlike => [qr/You are welcome/]);
159-
psql_command(
160-
$node, 'SELECT 1;', 2, 'try regress_mallory',
161-
connstr => 'user=regress_mallory',
162-
log_exact => '',
163-
err_like => [qr/You are NOT welcome/],
164-
err_unlike => [qr/You are welcome/]);
165154

166-
# Check that Alice's login record is here, while the Mallory's one is not
155+
# Check that Alice's login record is here
167156
psql_command(
168157
$node, 'SELECT * FROM user_logins;', 0, 'select *',
169158
log_like => [qr/3\|regress_alice/],

0 commit comments

Comments
 (0)