Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 087a933

Browse files
committed
Remove expensive test of postgres_fdw batch inserts
The test inserted 70k rows into a foreign table, in order to verify correct behavior with more than 65535 parameters, and was added in response to a bug report. However, this is rather expensive, especially when running the tests under valgrind, CLOBBER_CACHE_ALWAYS etc. It doesn't seem worth it to keep running the test, so remove it from all branches (14+). Backpatch-through: 14 Discussion: https://postgr.es/m/2131017.1623451468@sss.pgh.pa.us
1 parent 9436535 commit 087a933

File tree

2 files changed

+0
-18
lines changed

2 files changed

+0
-18
lines changed

contrib/postgres_fdw/expected/postgres_fdw.out

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10346,17 +10346,6 @@ SELECT COUNT(*) FROM ftable;
1034610346
34
1034710347
(1 row)
1034810348

10349-
TRUNCATE batch_table;
10350-
DROP FOREIGN TABLE ftable;
10351-
-- try if large batches exceed max number of bind parameters
10352-
CREATE FOREIGN TABLE ftable ( x int ) SERVER loopback OPTIONS ( table_name 'batch_table', batch_size '100000' );
10353-
INSERT INTO ftable SELECT * FROM generate_series(1, 70000) i;
10354-
SELECT COUNT(*) FROM ftable;
10355-
count
10356-
-------
10357-
70000
10358-
(1 row)
10359-
1036010349
TRUNCATE batch_table;
1036110350
DROP FOREIGN TABLE ftable;
1036210351
-- Disable batch insert

contrib/postgres_fdw/sql/postgres_fdw.sql

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3341,13 +3341,6 @@ SELECT COUNT(*) FROM ftable;
33413341
TRUNCATE batch_table;
33423342
DROP FOREIGN TABLE ftable;
33433343

3344-
-- try if large batches exceed max number of bind parameters
3345-
CREATE FOREIGN TABLE ftable ( x int ) SERVER loopback OPTIONS ( table_name 'batch_table', batch_size '100000' );
3346-
INSERT INTO ftable SELECT * FROM generate_series(1, 70000) i;
3347-
SELECT COUNT(*) FROM ftable;
3348-
TRUNCATE batch_table;
3349-
DROP FOREIGN TABLE ftable;
3350-
33513344
-- Disable batch insert
33523345
CREATE FOREIGN TABLE ftable ( x int ) SERVER loopback OPTIONS ( table_name 'batch_table', batch_size '1' );
33533346
EXPLAIN (VERBOSE, COSTS OFF) INSERT INTO ftable VALUES (1), (2);

0 commit comments

Comments
 (0)