Fix a probably-harmless read of uninitialized memory in mkdir_p(), to

Neil Conway · Neil Conway · commit 08b0e605636d · 2004-01-31T22:10:00.000Z
silence a valgrind warning.
diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
@@ -43,7 +43,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  * Portions taken from FreeBSD.
  *
- * $PostgreSQL: pgsql/src/bin/initdb/initdb.c,v 1.20 2004/01/31 21:18:00 neilc Exp $
+ * $PostgreSQL: pgsql/src/bin/initdb/initdb.c,v 1.21 2004/01/31 22:10:00 neilc Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -553,7 +553,7 @@ mkdir_p(char *path, mode_t omode)
 		else if (p[0] != '/')
 			continue;
 		*p = '\0';
-		if (p[1] == '\0')
+		if (!last && p[1] == '\0')
 			last = 1;
 		if (first)
 		{

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@`
`43`	`43`	`* Portions Copyright (c) 1994, Regents of the University of California`
`44`	`44`	`* Portions taken from FreeBSD.`
`45`	`45`	`*`
`46`		`- * $PostgreSQL: pgsql/src/bin/initdb/initdb.c,v 1.20 2004/01/31 21:18:00 neilc Exp $`
	`46`	`+ * $PostgreSQL: pgsql/src/bin/initdb/initdb.c,v 1.21 2004/01/31 22:10:00 neilc Exp $`
`47`	`47`	`*`
`48`	`48`	`*-------------------------------------------------------------------------`
`49`	`49`	`*/`
`@@ -553,7 +553,7 @@ mkdir_p(char *path, mode_t omode)`
`553`	`553`	`else if (p[0] != '/')`
`554`	`554`	`continue;`
`555`	`555`	`*p = '\0';`
`556`		`- if (p[1] == '\0')`
	`556`	`+ if (!last && p[1] == '\0')`
`557`	`557`	`last = 1;`
`558`	`558`	`if (first)`
`559`	`559`	`{`