Fix XXX comment about JsonAnalyzeContext.maxdepth

Nikita Glukhov · Nikita Glukhov · commit 08b9002ec082 · 2022-01-23T01:00:51.000+03:00
diff --git a/src/backend/utils/adt/jsonb_typanalyze.c b/src/backend/utils/adt/jsonb_typanalyze.c
@@ -292,8 +292,8 @@ jsonAnalyzeAddPath(JsonAnalyzeContext *ctx, JsonPath parent,
 		stats->entries = NULL;
 		stats->nentries = 0;
 
-		/* XXX Seems strange. Should we even add the path in this case? */
-		if (stats->depth > ctx->maxdepth)
+		/* update maximal depth */
+		if (ctx->maxdepth < stats->depth)
 			ctx->maxdepth = stats->depth;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -292,8 +292,8 @@ jsonAnalyzeAddPath(JsonAnalyzeContext *ctx, JsonPath parent,`
`292`	`292`	`stats->entries = NULL;`
`293`	`293`	`stats->nentries = 0;`
`294`	`294`
`295`		`- /* XXX Seems strange. Should we even add the path in this case? */`
`296`		`- if (stats->depth > ctx->maxdepth)`
	`295`	`+ /* update maximal depth */`
	`296`	`+ if (ctx->maxdepth < stats->depth)`
`297`	`297`	`ctx->maxdepth = stats->depth;`
`298`	`298`	`}`
`299`	`299`