Avoid incorrectly granting replication to roles created with NOSUPERUSER.

robertmhaas · robertmhaas · commit 0a49c95c734d · 2011-04-13T12:28:53.000-07:00
Andres Freund
diff --git a/src/backend/commands/user.c b/src/backend/commands/user.c
@@ -245,7 +245,7 @@ CreateRole(CreateRoleStmt *stmt)
 		 * Superusers get replication by default, but only if NOREPLICATION
 		 * wasn't explicitly mentioned
 		 */
-		if (!(disreplication && intVal(disreplication->arg) == 0))
+		if (issuper && !(disreplication && intVal(disreplication->arg) == 0))
 			isreplication = 1;
 	}
 	if (dinherit)

Original file line number	Diff line number	Diff line change
`@@ -245,7 +245,7 @@ CreateRole(CreateRoleStmt *stmt)`
`245`	`245`	`* Superusers get replication by default, but only if NOREPLICATION`
`246`	`246`	`* wasn't explicitly mentioned`
`247`	`247`	`*/`
`248`		`- if (!(disreplication && intVal(disreplication->arg) == 0))`
	`248`	`+ if (issuper && !(disreplication && intVal(disreplication->arg) == 0))`
`249`	`249`	`isreplication = 1;`
`250`	`250`	`}`
`251`	`251`	`if (dinherit)`