libpq: Fix memory leak

petere · petere · commit 0ba7ff5fa542 · 2012-03-11T00:47:36.000+02:00
If a client encoding is specified as a connection parameter (or
environment variable), internal storage allocated for it would never
be freed.
diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
@@ -2744,6 +2744,8 @@ freePGconn(PGconn *conn)
 		free(conn->events[i].name);
 	}
 
+	if (conn->client_encoding_initial)
+		free(conn->client_encoding_initial);
 	if (conn->events)
 		free(conn->events);
 	if (conn->pghost)

Original file line number	Diff line number	Diff line change
`@@ -2744,6 +2744,8 @@ freePGconn(PGconn *conn)`
`2744`	`2744`	`free(conn->events[i].name);`
`2745`	`2745`	`}`
`2746`	`2746`
	`2747`	`+ if (conn->client_encoding_initial)`
	`2748`	`+ free(conn->client_encoding_initial);`
`2747`	`2749`	`if (conn->events)`
`2748`	`2750`	`free(conn->events);`
`2749`	`2751`	`if (conn->pghost)`