Fix bug in propagating ALTER TABLE actions to typed tables.

robertmhaas · robertmhaas · commit 0bd155cbf254 · 2011-04-08T15:46:13.000-04:00
We need to propagate such actions to all typed table children of a
given type, not just the first one.

Noah Misch
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -4014,7 +4014,7 @@ find_typed_table_dependencies(Oid typeOid, const char *typeName, DropBehavior be
 
 	scan = heap_beginscan(classRel, SnapshotNow, 1, key);
 
-	if (HeapTupleIsValid(tuple = heap_getnext(scan, ForwardScanDirection)))
+	while ((tuple = heap_getnext(scan, ForwardScanDirection)) != NULL)
 	{
 		if (behavior == DROP_RESTRICT)
 			ereport(ERROR,

Original file line number	Diff line number	Diff line change
`@@ -4014,7 +4014,7 @@ find_typed_table_dependencies(Oid typeOid, const char *typeName, DropBehavior be`
`4014`	`4014`
`4015`	`4015`	`scan = heap_beginscan(classRel, SnapshotNow, 1, key);`
`4016`	`4016`
`4017`		`- if (HeapTupleIsValid(tuple = heap_getnext(scan, ForwardScanDirection)))`
	`4017`	`+ while ((tuple = heap_getnext(scan, ForwardScanDirection)) != NULL)`
`4018`	`4018`	`{`
`4019`	`4019`	`if (behavior == DROP_RESTRICT)`
`4020`	`4020`	`ereport(ERROR,`