Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 0ec2978

Browse files
committed
Revert "Add valgrind suppressions for wcsrtombs optimizations"
This reverts commit bf070ce. Per discussion, it's not desirable to add valgrind suppressions for outside our own code base (e.g. glibc in this case), especially when the suppressions may be platform-specific. There are better ways to deal with that, e.g. by providing local suppressions. Discussion: https://www.postgresql.org/message-id/flat/90ac0452-e907-e7a4-b3c8-15bd33780e62%402ndquadrant.com
1 parent 5279c8d commit 0ec2978

File tree

1 file changed

+0
-36
lines changed

1 file changed

+0
-36
lines changed

src/tools/valgrind.supp

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -212,39 +212,3 @@
212212
Memcheck:Cond
213213
fun:PyObject_Realloc
214214
}
215-
216-
# wcsrtombs uses some clever optimizations internally, which to valgrind
217-
# may look like access to uninitialized data. For example AVX2 instructions
218-
# load data in 256-bit chunks, irrespectedly of wchar length. gconv does
219-
# somethink similar by loading data in 32bit chunks and then shifting the
220-
# data internally. Neither of those actually uses the uninitialized part
221-
# of the buffer, as far as we know.
222-
#
223-
# https://www.postgresql.org/message-id/90ac0452-e907-e7a4-b3c8-15bd33780e62@2ndquadrant.com
224-
225-
{
226-
wcsnlen_optimized
227-
Memcheck:Cond
228-
...
229-
fun:wcsrtombs
230-
fun:wcstombs
231-
fun:wchar2char
232-
}
233-
234-
{
235-
wcsnlen_optimized_addr32
236-
Memcheck:Addr32
237-
...
238-
fun:wcsrtombs
239-
fun:wcstombs
240-
fun:wchar2char
241-
}
242-
243-
{
244-
gconv_transform_internal
245-
Memcheck:Cond
246-
fun:__gconv_transform_internal_utf8
247-
fun:wcsrtombs
248-
fun:wcstombs
249-
fun:wchar2char
250-
}

0 commit comments

Comments
 (0)