Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 0fc68c8

Browse files
committed
Fix issue in recovery test 041_checkpoint_at_promote
The phase of the test waiting for a restartpoint to complete was not working as intended, due to a log_contains() call incorrectly written. The problem reported by the author could be simply reproduced by removing the injection_points_wakeup() call: the test succeeds rather than waiting for the restartpoint completion. In most cases, the restartpoint completion is fast enough that the test offered the wanted coverage. On slow machines, it could have become unreliable. Oversight in 6782709. Author: Nitin Jadhav Discussion: https://postgr.es/m/CAMm1aWa_6u+o52r7h7G6pX-oWD0Qraf0ee17Ma50qxGS0B_Rzg@mail.gmail.com Backpatch-through: 17
1 parent 5b94e27 commit 0fc68c8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/test/recovery/t/041_checkpoint_at_promote.pl

+1-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@
110110
my $checkpoint_complete = 0;
111111
foreach my $i (0 .. 10 * $PostgreSQL::Test::Utils::timeout_default)
112112
{
113-
if ($node_standby->log_contains("restartpoint complete"), $logstart)
113+
if ($node_standby->log_contains("restartpoint complete", $logstart))
114114
{
115115
$checkpoint_complete = 1;
116116
last;

0 commit comments

Comments
 (0)