Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 10baee0

Browse files
committed
Add comments on some MinimalTupleSlots methods usage
Discussion: https://postgr.es/m/CALT9ZEHNeagO5PLb4Nv9J_ZaCtp%2BArdVmbSLc0RHUzx_RPAa4w%40mail.gmail.com Author: Pavel Borisov
1 parent c6f09e1 commit 10baee0

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

src/backend/executor/execTuples.c

+9
Original file line numberDiff line numberDiff line change
@@ -549,6 +549,10 @@ tts_minimal_getsomeattrs(TupleTableSlot *slot, int natts)
549549
slot_deform_heap_tuple(slot, mslot->tuple, &mslot->off, natts);
550550
}
551551

552+
/*
553+
* MinimalTupleTableSlots never provide system attributes. We generally
554+
* shouldn't get here, but provide a user-friendly message if we do.
555+
*/
552556
static Datum
553557
tts_minimal_getsysattr(TupleTableSlot *slot, int attnum, bool *isnull)
554558
{
@@ -561,6 +565,11 @@ tts_minimal_getsysattr(TupleTableSlot *slot, int attnum, bool *isnull)
561565
return 0; /* silence compiler warnings */
562566
}
563567

568+
/*
569+
* Within MinimalTuple abstraction transaction information is unavailable.
570+
* We generally shouldn't get here, but provide a user-friendly message if
571+
* we do.
572+
*/
564573
static bool
565574
tts_minimal_is_current_xact_tuple(TupleTableSlot *slot)
566575
{

0 commit comments

Comments
 (0)