Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 11c1d55

Browse files
committed
Improve comments for parallel executor estimation functions.
The previous comment (which was copied as boilerplate from one file to the next) implied that it was the executor node itself which was being serialized, but that's not right. We're not serializing the executor nodes; we're just allowing them to store some additional information in DSM. Adjusts the comment to reflect this. Discussion: http://postgr.es/m/CA+TgmoaHVinxG=3h6qBAsyV8xaDyQwbzK7YZnYfE8nJFMK1=FA@mail.gmail.com
1 parent 9f295c0 commit 11c1d55

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

src/backend/executor/nodeBitmapHeapscan.c

+2-1
Original file line numberDiff line numberDiff line change
@@ -934,7 +934,8 @@ BitmapShouldInitializeSharedState(ParallelBitmapHeapState *pstate)
934934
/* ----------------------------------------------------------------
935935
* ExecBitmapHeapEstimate
936936
*
937-
* estimates the space required to serialize bitmap scan node.
937+
* Compute the amount of space we'll need in the parallel
938+
* query DSM, and inform pcxt->estimator about our needs.
938939
* ----------------------------------------------------------------
939940
*/
940941
void

src/backend/executor/nodeIndexonlyscan.c

+2-1
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,8 @@ ExecInitIndexOnlyScan(IndexOnlyScan *node, EState *estate, int eflags)
604604
/* ----------------------------------------------------------------
605605
* ExecIndexOnlyScanEstimate
606606
*
607-
* estimates the space required to serialize index-only scan node.
607+
* Compute the amount of space we'll need in the parallel
608+
* query DSM, and inform pcxt->estimator about our needs.
608609
* ----------------------------------------------------------------
609610
*/
610611
void

src/backend/executor/nodeIndexscan.c

+2-1
Original file line numberDiff line numberDiff line change
@@ -1644,7 +1644,8 @@ ExecIndexBuildScanKeys(PlanState *planstate, Relation index,
16441644
/* ----------------------------------------------------------------
16451645
* ExecIndexScanEstimate
16461646
*
1647-
* estimates the space required to serialize indexscan node.
1647+
* Compute the amount of space we'll need in the parallel
1648+
* query DSM, and inform pcxt->estimator about our needs.
16481649
* ----------------------------------------------------------------
16491650
*/
16501651
void

src/backend/executor/nodeSeqscan.c

+2-1
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,8 @@ ExecReScanSeqScan(SeqScanState *node)
289289
/* ----------------------------------------------------------------
290290
* ExecSeqScanEstimate
291291
*
292-
* estimates the space required to serialize seqscan node.
292+
* Compute the amount of space we'll need in the parallel
293+
* query DSM, and inform pcxt->estimator about our needs.
293294
* ----------------------------------------------------------------
294295
*/
295296
void

0 commit comments

Comments
 (0)