Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 11da9e5

Browse files
committed
Update findoidjoins notes for 7.1.
1 parent fce33c7 commit 11da9e5

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

contrib/findoidjoins/README.findoidjoins

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ it on anything but an empty database, such as template1.
99
Uses pgeasy library.
1010

1111
Run on an empty database, it returns the system join relationships (shown
12-
below for 7.0). Note that unexpected matches may indicate bogus entries
12+
below for 7.1). Note that unexpected matches may indicate bogus entries
1313
in system tables --- don't accept a peculiar match without question.
1414
In particular, a field shown as joining to more than one target table is
15-
probably messed up. In 7.0, the *only* field that should join to more
15+
probably messed up. In 7.1, the *only* field that should join to more
1616
than one target is pg_description.objoid. (Running make_oidjoins_check
1717
is an easy way to spot fields joining to more than one table, BTW.)
1818

@@ -27,14 +27,17 @@ revision in the patterns of cross-links between system tables.
2727
(Ideally we'd just regenerate the script as part of the regression
2828
tests themselves, but that seems too slow...)
2929

30+
NOTE: in 7.1, make_oidjoins_check produces two bogus join checks, one for
31+
pg_database.datlastsysoid => pg_description.oid and one for
32+
pg_class.relfilenode => pg_class.oid. These are artifacts and should not
33+
be added to the oidjoins regress test.
34+
3035
---------------------------------------------------------------------------
3136

32-
Join pg_aggregate.aggtransfn1 => pg_proc.oid
33-
Join pg_aggregate.aggtransfn2 => pg_proc.oid
37+
Join pg_aggregate.aggtransfn => pg_proc.oid
3438
Join pg_aggregate.aggfinalfn => pg_proc.oid
3539
Join pg_aggregate.aggbasetype => pg_type.oid
36-
Join pg_aggregate.aggtranstype1 => pg_type.oid
37-
Join pg_aggregate.aggtranstype2 => pg_type.oid
40+
Join pg_aggregate.aggtranstype => pg_type.oid
3841
Join pg_aggregate.aggfinaltype => pg_type.oid
3942
Join pg_am.amgettuple => pg_proc.oid
4043
Join pg_am.aminsert => pg_proc.oid
@@ -56,8 +59,8 @@ Join pg_attribute.attrelid => pg_class.oid
5659
Join pg_attribute.atttypid => pg_type.oid
5760
Join pg_class.reltype => pg_type.oid
5861
Join pg_class.relam => pg_am.oid
59-
Join pg_description.objoid => pg_proc.oid
60-
Join pg_description.objoid => pg_type.oid
62+
Join pg_class.reltoastrelid => pg_class.oid
63+
Join pg_class.reltoastidxid => pg_class.oid
6164
Join pg_index.indexrelid => pg_class.oid
6265
Join pg_index.indrelid => pg_class.oid
6366
Join pg_opclass.opcdeftype => pg_type.oid

0 commit comments

Comments
 (0)