DropTableSpace forgot to remove dependency on tablespace's owner.

tglsfdc · tglsfdc · commit 13065c7174ea · 2005-08-30T01:08:47.000Z
Per report from Jaime Casanova.
diff --git a/src/backend/commands/tablespace.c b/src/backend/commands/tablespace.c
@@ -37,7 +37,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/tablespace.c,v 1.26 2005/07/14 21:46:29 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/tablespace.c,v 1.27 2005/08/30 01:08:47 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -446,6 +446,11 @@ DropTableSpace(DropTableSpaceStmt *stmt)
 
 	heap_endscan(scandesc);
 
+	/*
+	 * Remove dependency on owner.
+	 */
+	deleteSharedDependencyRecordsFor(TableSpaceRelationId, tablespaceoid);
+
 	/*
 	 * Try to remove the physical infrastructure
 	 */

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@`
`37`	`37`	`*`
`38`	`38`	`*`
`39`	`39`	`* IDENTIFICATION`
`40`		`- * $PostgreSQL: pgsql/src/backend/commands/tablespace.c,v 1.26 2005/07/14 21:46:29 tgl Exp $`
	`40`	`+ * $PostgreSQL: pgsql/src/backend/commands/tablespace.c,v 1.27 2005/08/30 01:08:47 tgl Exp $`
`41`	`41`	`*`
`42`	`42`	`*-------------------------------------------------------------------------`
`43`	`43`	`*/`
`@@ -446,6 +446,11 @@ DropTableSpace(DropTableSpaceStmt *stmt)`
`446`	`446`
`447`	`447`	`heap_endscan(scandesc);`
`448`	`448`
	`449`	`+ /*`
	`450`	`+ * Remove dependency on owner.`
	`451`	`+ */`
	`452`	`+ deleteSharedDependencyRecordsFor(TableSpaceRelationId, tablespaceoid);`
	`453`	`+`
`449`	`454`	`/*`
`450`	`455`	`* Try to remove the physical infrastructure`
`451`	`456`	`*/`