Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 13b3b62

Browse files
committed
Don't use the pg_am system catalog in new test
This causes deadlocks because it's a highly trafficked catalog. Use a regular table created by the same test instead. Discussion: https://postgr.es/m/f3e61e27-19d0-5e40-3eb2-53282fa0532a@gmail.com
1 parent 867cc7b commit 13b3b62

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/test/regress/expected/create_am.out

+2-2
Original file line numberDiff line numberDiff line change
@@ -548,8 +548,8 @@ ERROR: access method "I do not exist AM" does not exist
548548
CREATE TABLE i_am_a_failure() USING "btree";
549549
ERROR: access method "btree" is not of type TABLE
550550
-- Other weird invalid cases that cause problems
551-
CREATE FOREIGN TABLE fp PARTITION OF pg_am DEFAULT SERVER x;
552-
ERROR: "pg_am" is not partitioned
551+
CREATE FOREIGN TABLE fp PARTITION OF tableam_parted_a_heap2 DEFAULT SERVER x;
552+
ERROR: "tableam_parted_a_heap2" is not partitioned
553553
-- Drop table access method, which fails as objects depends on it
554554
DROP ACCESS METHOD heap2;
555555
ERROR: cannot drop access method heap2 because other objects depend on it

src/test/regress/sql/create_am.sql

+1-1
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ CREATE TABLE i_am_a_failure() USING "I do not exist AM";
349349
CREATE TABLE i_am_a_failure() USING "btree";
350350

351351
-- Other weird invalid cases that cause problems
352-
CREATE FOREIGN TABLE fp PARTITION OF pg_am DEFAULT SERVER x;
352+
CREATE FOREIGN TABLE fp PARTITION OF tableam_parted_a_heap2 DEFAULT SERVER x;
353353

354354
-- Drop table access method, which fails as objects depends on it
355355
DROP ACCESS METHOD heap2;

0 commit comments

Comments
 (0)